Bug 1495964 - Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato
authorMasayuki Nakano <masayuki@d-toybox.com>
Thu, 04 Oct 2018 02:51:16 +0000
changeset 439513 323691f11567176e1e70a6d49a628e2ed653de6e
parent 439512 2735d9fa61d7b0623b2a9c63cc68ff6b5ba83f7d
child 439514 9eff0dcbd18f0b29bd6f6f7bcb2707404ca58935
push id34777
push usernbeleuzu@mozilla.com
push dateThu, 04 Oct 2018 09:26:06 +0000
treeherdermozilla-central@f87eeba88f1c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersm_kato
bugs1495964, 1446401
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1495964 - Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato The assertion was reasonable check before fixing bug 1446401. However, this is currently valid situation in UI Events spec. Differential Revision: https://phabricator.services.mozilla.com/D7578
widget/cocoa/nsChildView.mm
--- a/widget/cocoa/nsChildView.mm
+++ b/widget/cocoa/nsChildView.mm
@@ -1466,20 +1466,16 @@ nsresult
 nsChildView::DispatchEvent(WidgetGUIEvent* event, nsEventStatus& aStatus)
 {
   RefPtr<nsChildView> kungFuDeathGrip(this);
 
 #ifdef DEBUG
   debug_DumpEvent(stdout, event->mWidget, event, "something", 0);
 #endif
 
-  NS_ASSERTION(!(mTextInputHandler && mTextInputHandler->IsIMEComposing() &&
-                 event->HasKeyEventMessage()),
-    "Any key events should not be fired during IME composing");
-
   if (event->mFlags.mIsSynthesizedForTests) {
     WidgetKeyboardEvent* keyEvent = event->AsKeyboardEvent();
     if (keyEvent) {
       nsresult rv = mTextInputHandler->AttachNativeKeyEvent(*keyEvent);
       NS_ENSURE_SUCCESS(rv, rv);
     }
   }