mozilla-central: changeset 413948:32220a5b1ba8827b89a099b1c7ebd02a88e18241

author	Brian Grinstead <bgrinstead@mozilla.com>
	Mon, 16 Apr 2018 11:05:01 -0700
changeset 413948	32220a5b1ba8827b89a099b1c7ebd02a88e18241
parent 413947	229be2ad5ee3a60ddc31568792725bee2a6564dc
child 413949	77694987ba61cf176fc403badc29431158f3f831
push id	33853
push user	cbrindusan@mozilla.com
push date	Tue, 17 Apr 2018 09:51:13 +0000
treeherder	mozilla-central@8b0ba3f7d099 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	Gijs
bugs	1454440
milestone	61.0a1
first release with	nightly linux32 f94b64e00202 / 61.0a1 / 20180417100054 / files nightly linux64 f94b64e00202 / 61.0a1 / 20180417100054 / files nightly mac f94b64e00202 / 61.0a1 / 20180417100054 / files nightly win32 f94b64e00202 / 61.0a1 / 20180417100054 / files nightly win64 f94b64e00202 / 61.0a1 / 20180417100054 / files
last release without	nightly linux32 6276ec7ebbf3 / 61.0a1 / 20180416100103 / files nightly linux64 6276ec7ebbf3 / 61.0a1 / 20180416100103 / files nightly mac 6276ec7ebbf3 / 61.0a1 / 20180416100103 / files nightly win32 e96685584bf7 / 61.0a1 / 20180415220108 / files nightly win64 e96685584bf7 / 61.0a1 / 20180415220108 / files

Bug 1454440 - Focus the window directly instead of using commandDispatcher in the mac Window menu;r=Gijs This fixes the Window menu with top-level HTML windows, which don't have `commandDispatcher` defined on the document. MozReview-Commit-ID: I7T1LrMf8Ik

toolkit/content/macWindowMenu.js

file | annotate | diff | comparison | revisions

--- a/toolkit/content/macWindowMenu.js
+++ b/toolkit/content/macWindowMenu.js
@@ -16,17 +16,17 @@ function macWindowMenuDidShow() {
     item.setAttribute("label", win.document.title);
     if (win == window) {
       item.setAttribute("checked", "true");
     }
     item.addEventListener("command", () => {
       if (win.windowState == window.STATE_MINIMIZED) {
         win.restore();
       }
-      win.document.commandDispatcher.focusedWindow.focus();
+      win.focus();
     });
     frag.appendChild(item);
   }
   document.getElementById("windowPopup").appendChild(frag);
 }
 
 function macWindowMenuDidHide() {
   let sep = document.getElementById("sep-window-list");