Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel
authorJunior Hsu <juhsu@mozilla.com>
Mon, 29 Jul 2019 22:42:39 +0000
changeset 485221 31c85754cf9441246e506fe95f64908638d7f22a
parent 485220 32f944ce7a046d9a8ad1ccae0747b8a4e09c36a5
child 485222 bd17824c618e8968284b1a3f1acbed9c140fd69b
push id36361
push userapavel@mozilla.com
push dateTue, 30 Jul 2019 09:49:32 +0000
treeherdermozilla-central@639f502ded6b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstnikkel
bugs1569772
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D39795
image/decoders/icon/win/nsIconChannel.cpp
--- a/image/decoders/icon/win/nsIconChannel.cpp
+++ b/image/decoders/icon/win/nsIconChannel.cpp
@@ -165,16 +165,20 @@ nsIconChannel::IconSyncOpenTask::Run() {
 // nsIconChannel methods
 nsIconChannel::nsIconChannel() {}
 
 nsIconChannel::~nsIconChannel() {
   if (mLoadInfo) {
     NS_ReleaseOnMainThreadSystemGroup("nsIconChannel::mLoadInfo",
                                       mLoadInfo.forget());
   }
+  if (mLoadGroup) {
+    NS_ReleaseOnMainThreadSystemGroup("nsIconChannel::mLoadGroup",
+                                      mLoadGroup.forget());
+  }
 }
 
 NS_IMPL_ISUPPORTS(nsIconChannel, nsIChannel, nsIRequest, nsIRequestObserver,
                   nsIStreamListener)
 
 nsresult nsIconChannel::Init(nsIURI* uri) {
   NS_ASSERTION(uri, "no uri");
   mUrl = uri;