Bug 1411605 - don't memset the entire mCodecSpecificInfo. r=dminor
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Thu, 26 Oct 2017 12:20:26 +0300
changeset 388423 30e090a9e408153c80b84bd045a02fa8ab014322
parent 388422 2fa4b23d5e7e7fb2975de3082bf5ed3439427b7e
child 388424 8c3b1c45afa6c27ee10c7697d2fad370afdf3d4e
push id32750
push userarchaeopteryx@coole-files.de
push dateThu, 26 Oct 2017 21:56:27 +0000
treeherdermozilla-central@a6d7be4ac1e3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdminor
bugs1411605
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1411605 - don't memset the entire mCodecSpecificInfo. r=dminor MozReview-Commit-ID: DEJXdfAuZrl
media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp
--- a/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp
+++ b/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp
@@ -159,17 +159,19 @@ WebrtcGmpVideoEncoder::InitEncode(const 
 
   codecParams.mGMPApiVersion = 33;
   codecParams.mStartBitrate = aCodecSettings->startBitrate;
   codecParams.mMinBitrate = aCodecSettings->minBitrate;
   codecParams.mMaxBitrate = aCodecSettings->maxBitrate;
   codecParams.mMaxFramerate = aCodecSettings->maxFramerate;
   mMaxPayloadSize = aMaxPayloadSize;
 
-  memset(&mCodecSpecificInfo, 0, sizeof(webrtc::CodecSpecificInfo));
+  memset(&mCodecSpecificInfo.codecSpecific,
+         0,
+         sizeof(mCodecSpecificInfo.codecSpecific));
   mCodecSpecificInfo.codecType = webrtc::kVideoCodecH264;
   mCodecSpecificInfo.codecSpecific.H264.packetization_mode =
     aCodecSettings->H264().packetizationMode == 1 ?
     webrtc::H264PacketizationMode::NonInterleaved :
     webrtc::H264PacketizationMode::SingleNalUnit;
 
   if (mCodecSpecificInfo.codecSpecific.H264.packetization_mode ==
       webrtc::H264PacketizationMode::NonInterleaved) {