Bug 972844 - Add a Maybe Later link on about:feedback intro [r=mfinkle]
authorMatt Brubeck <mbrubeck@mozilla.com>
Tue, 04 Mar 2014 16:58:33 -0800
changeset 171847 2f7d8cae0854a9e69d3f8b02f894a75fb9777d3c
parent 171846 b7858028c7813d960d97f460c28a79481dd1564e
child 171848 619010dcdffcae4c858f7b207da0ab61be0c1790
push id26341
push userttaubert@mozilla.com
push dateWed, 05 Mar 2014 08:55:37 +0000
treeherdermozilla-central@ee131fc23afd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs972844
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 972844 - Add a Maybe Later link on about:feedback intro [r=mfinkle]
mobile/android/chrome/content/aboutFeedback.js
mobile/android/chrome/content/aboutFeedback.xhtml
--- a/mobile/android/chrome/content/aboutFeedback.js
+++ b/mobile/android/chrome/content/aboutFeedback.js
@@ -27,19 +27,19 @@ function init() {
   document.getElementById("sad-link").addEventListener("click", function(evt) {
     switchSection("sad");
   }, false);
 
   window.addEventListener("unload", uninit, false);
 
   document.getElementById("open-play-store").addEventListener("click", openPlayStore, false);
   document.forms[0].addEventListener("submit", sendFeedback, false);
-  document.getElementById("no-thanks").addEventListener("click", function(evt) {
-    window.close();
-  }, false);
+  for (let anchor of document.querySelectorAll(".no-thanks")) {
+    anchor.addEventListener("click", evt => window.close(), false);
+  }
 
   let sumoLink = Services.urlFormatter.formatURLPref("app.support.baseURL");
   document.getElementById("sumo-link").href = sumoLink;
 
   window.addEventListener("popstate", function (aEvent) {
 	updateActiveSection(aEvent.state ? aEvent.state.section : "intro")
   }, false);
 
--- a/mobile/android/chrome/content/aboutFeedback.xhtml
+++ b/mobile/android/chrome/content/aboutFeedback.xhtml
@@ -30,32 +30,33 @@
     <div id="happy-link" class="link-box">
       <a>&intro.happyLink;</a>
     </div>
     <div id="sad-link" class="link-box-bottom">
       <a>&intro.sadLink;</a>
     </div>
     <div class="bottom-links">
       <a class="maybe-later">&intro.maybeLater;</a>
+      <a class="no-thanks">&happy.noThanks;</a>
     </div>
   </section>
 
   <section id="happy">
     <h1 class="header">&happy.header;</h1>
     <div class="message-box">
       <div class="message">&happy.message;</div>
       <div class="fine-print">&happy.finePrint;</div>
     </div>
     <div id="open-play-store" class="link-box-bottom">
       <div class="stars"/>
       <a>&happy.ratingLink;</a>
     </div>
     <div class="bottom-links">
       <a class="maybe-later">&happy.maybeLater2;</a>
-      <a id="no-thanks">&happy.noThanks;</a>
+      <a class="no-thanks">&happy.noThanks;</a>
     </div>
   </section>
 
   <section id="sad">
     <form>
       <div class="message">&sad.message;</div>
       <textarea class="description" placeholder="&sad.placeholder;" rows="8" required="true"/>
       <div class="message">&sad.lastSite;</div>