Bug 1525193 - Rename page-action.svg to more.svg, move to toolkit r=dao
authorMark Striemer <mstriemer@mozilla.com>
Fri, 15 Mar 2019 19:19:14 +0000
changeset 464427 2e1a91cd78fe003468ab4c4c625e9d300ad1709d
parent 464426 d57f48d6e42bc87ccc20f3350f49bf925d2d8bc2
child 464428 e08f9ad9fcbb171e7fa001d021b68a9103d431b4
push id35716
push useraciure@mozilla.com
push dateSun, 17 Mar 2019 09:42:17 +0000
treeherdermozilla-central@8ee97c045359 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1525193
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1525193 - Rename page-action.svg to more.svg, move to toolkit r=dao Differential Revision: https://phabricator.services.mozilla.com/D21293
browser/components/newtab/content-src/components/CollapsibleSection/_CollapsibleSection.scss
browser/components/newtab/content-src/styles/_variables.scss
browser/components/newtab/css/activity-stream-linux.css
browser/components/newtab/css/activity-stream-mac.css
browser/components/newtab/css/activity-stream-windows.css
browser/themes/shared/icons/page-action.svg
browser/themes/shared/jar.inc.mn
browser/themes/shared/urlbar-searchbar.inc.css
toolkit/themes/shared/icons/more.svg
toolkit/themes/shared/jar.inc.mn
--- a/browser/components/newtab/content-src/components/CollapsibleSection/_CollapsibleSection.scss
+++ b/browser/components/newtab/content-src/components/CollapsibleSection/_CollapsibleSection.scss
@@ -46,17 +46,17 @@
   }
 
   .section-top-bar {
     min-height: 19px;
     margin-bottom: 13px;
     position: relative;
 
     .context-menu-button {
-      background: url('chrome://browser/skin/page-action.svg') no-repeat right center;
+      background: url('chrome://global/skin/icons/more.svg') no-repeat right center;
       border: 0;
       cursor: pointer;
       fill: var(--newtab-section-header-text-color);
       height: 100%;
       inset-inline-end: 0;
       opacity: 0;
       position: absolute;
       top: 0;
--- a/browser/components/newtab/content-src/styles/_variables.scss
+++ b/browser/components/newtab/content-src/styles/_variables.scss
@@ -150,17 +150,17 @@
   box-shadow: $shadow-primary;
   transition: box-shadow 150ms;
 }
 
 @mixin context-menu-button {
   .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url('chrome://browser/skin/page-action.svg');
+    background-image: url('chrome://global/skin/icons/more.svg');
     background-position: 55%;
     border: $border-primary;
     border-radius: 100%;
     box-shadow: $context-menu-button-boxshadow;
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: $context-menu-button-size;
     inset-inline-end: -($context-menu-button-size / 2);
--- a/browser/components/newtab/css/activity-stream-linux.css
+++ b/browser/components/newtab/css/activity-stream-linux.css
@@ -503,17 +503,17 @@ main {
       display: block;
       outline: none; }
       .top-site-outer .top-site-inner > a:-moz-any(.active, :focus) .tile {
         box-shadow: inset 0 0 0 1px var(--newtab-inner-box-shadow-color), 0 0 0 5px var(--newtab-card-active-outline-color);
         transition: box-shadow 150ms; }
   .top-site-outer .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url("chrome://browser/skin/page-action.svg");
+    background-image: url("chrome://global/skin/icons/more.svg");
     background-position: 55%;
     border: 1px solid var(--newtab-border-primary-color);
     border-radius: 100%;
     box-shadow: 0 2px rgba(12, 12, 13, 0.1);
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: 27px;
     inset-inline-end: -13.5px;
@@ -1293,17 +1293,17 @@ main {
   display: inline-block;
   height: 266px;
   margin-inline-end: 32px;
   position: relative;
   width: 100%; }
   .card-outer .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url("chrome://browser/skin/page-action.svg");
+    background-image: url("chrome://global/skin/icons/more.svg");
     background-position: 55%;
     border: 1px solid var(--newtab-border-primary-color);
     border-radius: 100%;
     box-shadow: 0 2px rgba(12, 12, 13, 0.1);
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: 27px;
     inset-inline-end: -13.5px;
@@ -1585,17 +1585,17 @@ main {
     .collapsible-section .section-title .collapsible-arrow {
       margin-inline-start: 8px;
       margin-top: -1px; }
   .collapsible-section .section-top-bar {
     min-height: 19px;
     margin-bottom: 13px;
     position: relative; }
     .collapsible-section .section-top-bar .context-menu-button {
-      background: url("chrome://browser/skin/page-action.svg") no-repeat right center;
+      background: url("chrome://global/skin/icons/more.svg") no-repeat right center;
       border: 0;
       cursor: pointer;
       fill: var(--newtab-section-header-text-color);
       height: 100%;
       inset-inline-end: 0;
       opacity: 0;
       position: absolute;
       top: 0;
@@ -2486,17 +2486,17 @@ main {
   .ds-column-4 .ds-top-sites .top-site-inner .title {
     width: var(--rightPanelIconWidth); }
 
 .ds-hero-item .context-menu-button,
 .ds-list-item .context-menu-button,
 .ds-card .context-menu-button {
   background-clip: padding-box;
   background-color: var(--newtab-contextmenu-button-color);
-  background-image: url("chrome://browser/skin/page-action.svg");
+  background-image: url("chrome://global/skin/icons/more.svg");
   background-position: 55%;
   border: 1px solid var(--newtab-border-primary-color);
   border-radius: 100%;
   box-shadow: 0 2px rgba(12, 12, 13, 0.1);
   cursor: pointer;
   fill: var(--newtab-icon-primary-color);
   height: 27px;
   inset-inline-end: -13.5px;
--- a/browser/components/newtab/css/activity-stream-mac.css
+++ b/browser/components/newtab/css/activity-stream-mac.css
@@ -506,17 +506,17 @@ main {
       display: block;
       outline: none; }
       .top-site-outer .top-site-inner > a:-moz-any(.active, :focus) .tile {
         box-shadow: inset 0 0 0 1px var(--newtab-inner-box-shadow-color), 0 0 0 5px var(--newtab-card-active-outline-color);
         transition: box-shadow 150ms; }
   .top-site-outer .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url("chrome://browser/skin/page-action.svg");
+    background-image: url("chrome://global/skin/icons/more.svg");
     background-position: 55%;
     border: 1px solid var(--newtab-border-primary-color);
     border-radius: 100%;
     box-shadow: 0 2px rgba(12, 12, 13, 0.1);
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: 27px;
     inset-inline-end: -13.5px;
@@ -1296,17 +1296,17 @@ main {
   display: inline-block;
   height: 266px;
   margin-inline-end: 32px;
   position: relative;
   width: 100%; }
   .card-outer .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url("chrome://browser/skin/page-action.svg");
+    background-image: url("chrome://global/skin/icons/more.svg");
     background-position: 55%;
     border: 1px solid var(--newtab-border-primary-color);
     border-radius: 100%;
     box-shadow: 0 2px rgba(12, 12, 13, 0.1);
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: 27px;
     inset-inline-end: -13.5px;
@@ -1588,17 +1588,17 @@ main {
     .collapsible-section .section-title .collapsible-arrow {
       margin-inline-start: 8px;
       margin-top: -1px; }
   .collapsible-section .section-top-bar {
     min-height: 19px;
     margin-bottom: 13px;
     position: relative; }
     .collapsible-section .section-top-bar .context-menu-button {
-      background: url("chrome://browser/skin/page-action.svg") no-repeat right center;
+      background: url("chrome://global/skin/icons/more.svg") no-repeat right center;
       border: 0;
       cursor: pointer;
       fill: var(--newtab-section-header-text-color);
       height: 100%;
       inset-inline-end: 0;
       opacity: 0;
       position: absolute;
       top: 0;
@@ -2489,17 +2489,17 @@ main {
   .ds-column-4 .ds-top-sites .top-site-inner .title {
     width: var(--rightPanelIconWidth); }
 
 .ds-hero-item .context-menu-button,
 .ds-list-item .context-menu-button,
 .ds-card .context-menu-button {
   background-clip: padding-box;
   background-color: var(--newtab-contextmenu-button-color);
-  background-image: url("chrome://browser/skin/page-action.svg");
+  background-image: url("chrome://global/skin/icons/more.svg");
   background-position: 55%;
   border: 1px solid var(--newtab-border-primary-color);
   border-radius: 100%;
   box-shadow: 0 2px rgba(12, 12, 13, 0.1);
   cursor: pointer;
   fill: var(--newtab-icon-primary-color);
   height: 27px;
   inset-inline-end: -13.5px;
--- a/browser/components/newtab/css/activity-stream-windows.css
+++ b/browser/components/newtab/css/activity-stream-windows.css
@@ -503,17 +503,17 @@ main {
       display: block;
       outline: none; }
       .top-site-outer .top-site-inner > a:-moz-any(.active, :focus) .tile {
         box-shadow: inset 0 0 0 1px var(--newtab-inner-box-shadow-color), 0 0 0 5px var(--newtab-card-active-outline-color);
         transition: box-shadow 150ms; }
   .top-site-outer .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url("chrome://browser/skin/page-action.svg");
+    background-image: url("chrome://global/skin/icons/more.svg");
     background-position: 55%;
     border: 1px solid var(--newtab-border-primary-color);
     border-radius: 100%;
     box-shadow: 0 2px rgba(12, 12, 13, 0.1);
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: 27px;
     inset-inline-end: -13.5px;
@@ -1293,17 +1293,17 @@ main {
   display: inline-block;
   height: 266px;
   margin-inline-end: 32px;
   position: relative;
   width: 100%; }
   .card-outer .context-menu-button {
     background-clip: padding-box;
     background-color: var(--newtab-contextmenu-button-color);
-    background-image: url("chrome://browser/skin/page-action.svg");
+    background-image: url("chrome://global/skin/icons/more.svg");
     background-position: 55%;
     border: 1px solid var(--newtab-border-primary-color);
     border-radius: 100%;
     box-shadow: 0 2px rgba(12, 12, 13, 0.1);
     cursor: pointer;
     fill: var(--newtab-icon-primary-color);
     height: 27px;
     inset-inline-end: -13.5px;
@@ -1585,17 +1585,17 @@ main {
     .collapsible-section .section-title .collapsible-arrow {
       margin-inline-start: 8px;
       margin-top: -1px; }
   .collapsible-section .section-top-bar {
     min-height: 19px;
     margin-bottom: 13px;
     position: relative; }
     .collapsible-section .section-top-bar .context-menu-button {
-      background: url("chrome://browser/skin/page-action.svg") no-repeat right center;
+      background: url("chrome://global/skin/icons/more.svg") no-repeat right center;
       border: 0;
       cursor: pointer;
       fill: var(--newtab-section-header-text-color);
       height: 100%;
       inset-inline-end: 0;
       opacity: 0;
       position: absolute;
       top: 0;
@@ -2486,17 +2486,17 @@ main {
   .ds-column-4 .ds-top-sites .top-site-inner .title {
     width: var(--rightPanelIconWidth); }
 
 .ds-hero-item .context-menu-button,
 .ds-list-item .context-menu-button,
 .ds-card .context-menu-button {
   background-clip: padding-box;
   background-color: var(--newtab-contextmenu-button-color);
-  background-image: url("chrome://browser/skin/page-action.svg");
+  background-image: url("chrome://global/skin/icons/more.svg");
   background-position: 55%;
   border: 1px solid var(--newtab-border-primary-color);
   border-radius: 100%;
   box-shadow: 0 2px rgba(12, 12, 13, 0.1);
   cursor: pointer;
   fill: var(--newtab-icon-primary-color);
   height: 27px;
   inset-inline-end: -13.5px;
--- a/browser/themes/shared/jar.inc.mn
+++ b/browser/themes/shared/jar.inc.mn
@@ -170,17 +170,16 @@
   skin/classic/browser/library-pocket-animation.svg   (../shared/icons/library-pocket-animation.svg)
   skin/classic/browser/link.svg                       (../shared/icons/link.svg)
   skin/classic/browser/mail.svg                       (../shared/icons/mail.svg)
   skin/classic/browser/menu.svg                       (../shared/icons/menu.svg)
   skin/classic/browser/menu-badged.svg                (../shared/icons/menu-badged.svg)
   skin/classic/browser/new-tab.svg                    (../shared/icons/new-tab.svg)
   skin/classic/browser/new-window.svg                 (../shared/icons/new-window.svg)
   skin/classic/browser/open.svg                       (../shared/icons/open.svg)
-  skin/classic/browser/page-action.svg                (../shared/icons/page-action.svg)
   skin/classic/browser/pin-tab.svg                    (../shared/icons/pin-tab.svg)
   skin/classic/browser/pocket.svg                     (../shared/icons/pocket.svg)
   skin/classic/browser/pocket-animation.svg           (../shared/icons/pocket-animation.svg)
   skin/classic/browser/pocket-outline.svg             (../shared/icons/pocket-outline.svg)
   skin/classic/browser/print.svg                      (../shared/icons/print.svg)
   skin/classic/browser/private-browsing.svg           (../shared/icons/private-browsing.svg)
   skin/classic/browser/privateBrowsing.svg            (../shared/icons/privateBrowsing.svg)
   skin/classic/browser/restore-session.svg            (../shared/icons/restore-session.svg)
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -353,17 +353,17 @@
 
 #nav-bar:not([customizing="true"]) > #nav-bar-customization-target > #urlbar-container:not(:hover) > #urlbar:not([focused]) > .urlbar-history-dropmarker,
 #nav-bar:not([customizing="true"]) > #nav-bar-customization-target > #urlbar-container:not(:hover) > #urlbar.hidden-focus > .urlbar-history-dropmarker {
   opacity: 0;
 }
 
 #pageActionButton,
 .share-more-button {
-  list-style-image: url("chrome://browser/skin/page-action.svg");
+  list-style-image: url("chrome://global/skin/icons/more.svg");
 }
 
 @keyframes bookmark-animation {
   from {
     transform: translateX(0);
   }
   to {
     transform: translateX(-627px);
rename from browser/themes/shared/icons/page-action.svg
rename to toolkit/themes/shared/icons/more.svg
--- a/toolkit/themes/shared/jar.inc.mn
+++ b/toolkit/themes/shared/jar.inc.mn
@@ -36,16 +36,17 @@ toolkit.jar:
   skin/classic/global/icons/error.svg                      (../../shared/icons/error.svg)
   skin/classic/global/icons/find-previous-arrow.svg        (../../shared/icons/find-previous-arrow.svg)
   skin/classic/global/icons/find-next-arrow.svg            (../../shared/icons/find-next-arrow.svg)
   skin/classic/global/icons/heart.svg                      (../../shared/icons/heart.svg)
   skin/classic/global/icons/help.svg                       (../../shared/icons/help.svg)
   skin/classic/global/icons/info.svg                       (../../shared/incontent-icons/info.svg)
   skin/classic/global/icons/loading.png                    (../../shared/icons/loading.png)
   skin/classic/global/icons/loading@2x.png                 (../../shared/icons/loading@2x.png)
+  skin/classic/global/icons/more.svg                       (../../shared/icons/more.svg)
   skin/classic/global/icons/performance.svg                (../../shared/icons/performance.svg)
   skin/classic/global/icons/resizer.svg                    (../../shared/icons/resizer.svg)
   skin/classic/global/icons/shortcut.svg                   (../../shared/icons/shortcut.svg)
   skin/classic/global/icons/spinner-arrow-down.svg         (../../shared/icons/spinner-arrow-down.svg)
   skin/classic/global/icons/spinner-arrow-up.svg           (../../shared/icons/spinner-arrow-up.svg)
   skin/classic/global/icons/twisty-collapsed.svg           (../../shared/icons/twisty-collapsed.svg)
   skin/classic/global/icons/twisty-collapsed-rtl.svg       (../../shared/icons/twisty-collapsed-rtl.svg)
   skin/classic/global/icons/twisty-expanded.svg            (../../shared/icons/twisty-expanded.svg)