Bug 1586711 - Making the test 'browser/components/originattributes/test/browser/browser_localStorageIsolation.js' working in Fission. r=baku
authorTim Huang <tihuang@mozilla.com>
Tue, 15 Oct 2019 14:23:53 +0000
changeset 498333 2c7f637d7fc821b1f3b19434dcf967b698e3144b
parent 498332 87cadf9e3049575ea123746079e73a4b488628a3
child 498334 63396eab4b66da57b6c47582bbd5dbd785232d59
push id36717
push usernbeleuzu@mozilla.com
push dateMon, 21 Oct 2019 21:51:55 +0000
treeherdermozilla-central@563f437f24b9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1586711
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1586711 - Making the test 'browser/components/originattributes/test/browser/browser_localStorageIsolation.js' working in Fission. r=baku Depends on D49248 Differential Revision: https://phabricator.services.mozilla.com/D49249
browser/components/originattributes/test/browser/browser.ini
browser/components/originattributes/test/browser/browser_localStorageIsolation.js
--- a/browser/components/originattributes/test/browser/browser.ini
+++ b/browser/components/originattributes/test/browser/browser.ini
@@ -77,17 +77,16 @@ skip-if = fission || debug #Bug 1345346
 fail-if = fission
 [browser_firstPartyIsolation_blobURI.js]
 skip-if = fission # Crashes: @ mozilla::dom::BrowserBridgeParent::RecvShow(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, bool const&, nsSizeMode const&)
 [browser_firstPartyIsolation_js_uri.js]
 skip-if = fission
 [browser_firstPartyIsolation_saveAs.js]
 skip-if = fission
 [browser_localStorageIsolation.js]
-fail-if = fission
 [browser_blobURLIsolation.js]
 skip-if = (verify && debug && (os == 'win'))
 [browser_imageCacheIsolation.js]
 [browser_sharedworker.js]
 fail-if = fission
 [browser_httpauth.js]
 [browser_clientAuth.js]
 skip-if = verify
--- a/browser/components/originattributes/test/browser/browser_localStorageIsolation.js
+++ b/browser/components/originattributes/test/browser/browser_localStorageIsolation.js
@@ -6,17 +6,17 @@ const TEST_PAGE =
   "http://mochi.test:8888/browser/browser/components/" +
   "originattributes/test/browser/file_firstPartyBasic.html";
 
 // Use a random key so we don't access it in later tests.
 const key = Math.random().toString();
 
 // Define the testing function
 function doTest(aBrowser) {
-  return ContentTask.spawn(aBrowser, key, function(contentKey) {
+  return SpecialPowers.spawn(aBrowser, [key], function(contentKey) {
     let value = content.localStorage.getItem(contentKey);
     if (value === null) {
       // No value is found, so we create one.
       value = Math.random().toString();
       content.localStorage.setItem(contentKey, value);
     }
     return value;
   });