Bug 1354933. Assert that the frame pointer is null in the nsView destructor. r=mats
authorTimothy Nikkel <tnikkel@gmail.com>
Tue, 18 Apr 2017 18:17:35 -0500
changeset 353887 2c6ecadd506bd756b81f4a03adb386f2880a8b2f
parent 353886 8d0c392a6f4c47ff6f73b14b5ec8af096392bd87
child 353888 6d3e06aa0da8dc25cd7717e1d66a5aca4ea534d7
push id31681
push userkwierso@gmail.com
push dateThu, 20 Apr 2017 00:11:50 +0000
treeherdermozilla-central@20dff607fb88 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats
bugs1354933
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1354933. Assert that the frame pointer is null in the nsView destructor. r=mats
view/nsView.cpp
--- a/view/nsView.cpp
+++ b/view/nsView.cpp
@@ -111,16 +111,18 @@ nsView::~nsView()
 
   if (mPreviousWindow) {
     mPreviousWindow->SetPreviouslyAttachedWidgetListener(nullptr);
   }
 
   // Destroy and release the widget
   DestroyWidget();
 
+  MOZ_RELEASE_ASSERT(!mFrame);
+
   delete mDirtyRegion;
 }
 
 class DestroyWidgetRunnable : public Runnable {
 public:
   NS_DECL_NSIRUNNABLE
 
   explicit DestroyWidgetRunnable(nsIWidget* aWidget) : mWidget(aWidget) {}