Backed out changeset e50bc3e146bc (bug 1092370) for mochitest crashes/asserts.
authorRyan VanderMeulen <ryanvm@gmail.com>
Sat, 24 Jan 2015 13:58:12 -0500
changeset 225570 2c4faddcc7e77fe59aef561cbffba97d89d4c423
parent 225569 f313202b1e25cc0779c8287d3e3a34709fb018ff
child 225571 b369b09c60baa6f692abe2fce83a9982177c483a
push id28167
push userryanvm@gmail.com
push dateSun, 25 Jan 2015 00:24:46 +0000
treeherdermozilla-central@c18776175a69 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1092370
milestone38.0a1
backs oute50bc3e146bc37a10b90ad8a12d861364106793b
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset e50bc3e146bc (bug 1092370) for mochitest crashes/asserts.
dom/media/MP3FrameParser.cpp
--- a/dom/media/MP3FrameParser.cpp
+++ b/dom/media/MP3FrameParser.cpp
@@ -332,21 +332,16 @@ nsresult MP3FrameParser::ParseBuffer(con
   // If we haven't found any MP3 frame data yet, there might be ID3 headers
   // we can skip over.
   if (mMP3Offset < 0) {
     for (const uint8_t *ch = buffer; ch < bufferEnd; ch++) {
       if (mID3Parser.ParseChar(*ch)) {
         // Found an ID3 header. We don't care about the body of the header, so
         // just skip past.
         buffer = ch + mID3Parser.GetHeaderLength() - (ID3_HEADER_LENGTH - 1);
-
-        if (buffer <= ch || buffer >= bufferEnd) {
-          return NS_ERROR_FAILURE;
-        }
-
         ch = buffer;
 
         mTotalID3Size += mID3Parser.GetHeaderLength();
 
         // Yes, this is an MP3!
         mIsMP3 = DEFINITELY_MP3;
 
         mID3Parser.Reset();