Bug 1505428 raptor --page-cycles only works at 'subtest' level r=rwood
authorflorin.strugariu <bebe@mozilla.ro>
Fri, 09 Nov 2018 13:48:19 +0000
changeset 445418 2bed0d1d1abdf914b5cb4d2c04e1ee3872707a29
parent 445417 08de19d5e162077aa84c50f5ae8669c19456f568
child 445419 4c759f171cefc121537bfdcc2213a04effc72057
push id35015
push userdluca@mozilla.com
push dateFri, 09 Nov 2018 17:45:20 +0000
treeherdermozilla-central@2f1158e5e0ce [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrwood
bugs1505428
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1505428 raptor --page-cycles only works at 'subtest' level r=rwood Differential Revision: https://phabricator.services.mozilla.com/D11455
testing/raptor/raptor/manifest.py
--- a/testing/raptor/raptor/manifest.py
+++ b/testing/raptor/raptor/manifest.py
@@ -181,23 +181,25 @@ def get_raptor_test_list(args, oskey):
                          "to 3 for test %s" % next_test['name'])
                 next_test['page_cycles'] = 3
 
     # if --page-cycles command line arg was provided, override the page_cycles value
     # that was in the manifest/test INI with the command line arg value instead
     # also allow the cmd line opt to override pagecycles auto set when gecko profiling is on
     if args.page_cycles is not None:
         LOG.info("setting page-cycles to %d as specified on the command line" % args.page_cycles)
-        next_test['page_cycles'] = args.page_cycles
+        for next_test in tests_to_run:
+            next_test['page_cycles'] = args.page_cycles
 
     # if --page-timeout command line arg was provided, override the page_timeout value
     # that was in the manifest/test INI with the command line arg value instead
     if args.page_timeout is not None:
         LOG.info("setting page-timeout to %d as specified on the command line" % args.page_timeout)
-        next_test['page_timeout'] = args.page_timeout
+        for next_test in tests_to_run:
+            next_test['page_timeout'] = args.page_timeout
 
     # write out .json test setting files for the control server to read and send to web ext
     if len(tests_to_run) != 0:
         for test in tests_to_run:
             if validate_test_ini(test):
                 write_test_settings_json(test, oskey)
             else:
                 # test doesn't have valid settings, remove it from available list