Bug 1550697 - fix focus colours for banners in hamburger menu, r=ntim
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 21 May 2019 10:17:31 +0000
changeset 474696 2ad581fafc85ab939d75f7aa1a2f901f45ecb113
parent 474695 561a328e09ea3fc0e5fe93cf0c9d803b4695186f
child 474697 d2660d957f4212c0f80ed2c65487cabd300988a4
push id36044
push userrmaries@mozilla.com
push dateTue, 21 May 2019 15:45:34 +0000
treeherdermozilla-central@78571bb1f20e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim
bugs1550697
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550697 - fix focus colours for banners in hamburger menu, r=ntim Differential Revision: https://phabricator.services.mozilla.com/D31617
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -462,16 +462,17 @@ toolbarbutton[constrain-size="true"][cui
   border-inline-start-style: none;
   -moz-image-region: rect(0, 16px, 16px, 0);
 }
 
 .addon-banner-item:last-child {
   border-bottom: 1px solid @appmenuWarningBorderColor@;
 }
 
+.addon-banner-item:focus,
 .addon-banner-item:hover {
   background-color: @appmenuWarningBackgroundColorHover@;
 }
 
 .addon-banner-item:hover:active {
   background-color: @appmenuWarningBackgroundColorActive@;
 }
 
@@ -942,53 +943,57 @@ panelmultiview[mainViewId="PanelUI-fxa"]
   display: none;
 }
 
 .panel-banner-item {
   color: black !important /* !important overrides the toolbarbutton:hover default style on Linux */;
   background-color: hsla(96,65%,75%,.5);
 }
 
+.panel-banner-item:not([disabled]):focus,
 .panel-banner-item:not([disabled]):hover {
   background-color: hsla(96,65%,75%,.8);
 }
 
 .panel-banner-item:not([disabled]):hover:active {
   background-color: hsl(96,65%,75%);
 }
 
 :root[lwt-popup-brighttext] .panel-banner-item:not([disabled]) {
   background-color: rgba(48,230,11,.1);
   color: @appmenuWarningColorBrightText@ !important;
 }
 
+:root[lwt-popup-brighttext] .panel-banner-item:not([disabled]):focus,
 :root[lwt-popup-brighttext] .panel-banner-item:not([disabled]):hover {
   background-color: rgba(48,230,11,.15);
 }
 
 :root[lwt-popup-brighttext] .panel-banner-item:not([disabled]):active {
   background-color: rgba(48,230,11,.2);
 }
 
 .panel-banner-item[notificationid="update-unsupported"] {
   background-color: @appmenuWarningBackgroundColor@;
 }
 
+.panel-banner-item[notificationid="update-unsupported"]:not([disabled]):focus,
 .panel-banner-item[notificationid="update-unsupported"]:not([disabled]):hover {
   background-color: @appmenuWarningBackgroundColorHover@;
 }
 
 .panel-banner-item[notificationid="update-unsupported"]:not([disabled]):hover:active {
   background-color: @appmenuWarningBackgroundColorActive@;
 }
 
 :root[lwt-popup-brighttext] .panel-banner-item[notificationid="update-unsupported"]:not([disabled]) {
   background-color: @appmenuWarningBackgroundColorBrightText@;
 }
 
+:root[lwt-popup-brighttext] .panel-banner-item[notificationid="update-unsupported"]:not([disabled]):focus,
 :root[lwt-popup-brighttext] .panel-banner-item[notificationid="update-unsupported"]:not([disabled]):hover {
   background-color: @appmenuWarningBackgroundColorHoverBrightText@;
 }
 
 :root[lwt-popup-brighttext] .panel-banner-item[notificationid="update-unsupported"]:not([disabled]):active {
   background-color: @appmenuWarningBackgroundColorActiveBrightText@;
 }