Bug 843614 - Part 1: Enable test_outgoing_badNumber. r=hsinyi
authorEdgar Chen <echen@mozilla.com>
Mon, 18 Feb 2013 16:59:02 +0800
changeset 126541 2a0138828f01ce154b9efc72d9d7ab590171afe5
parent 126540 7a983737db1f95cc4318b4fe65f76adfd3d3488c
child 126542 76ba219af069428248354dffbdcc18bbb54ec474
push id24488
push userryanvm@gmail.com
push dateFri, 29 Mar 2013 00:54:52 +0000
treeherdermozilla-central@8aeabe064932 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershsinyi
bugs843614
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 843614 - Part 1: Enable test_outgoing_badNumber. r=hsinyi
dom/telephony/test/marionette/manifest.ini
dom/telephony/test/marionette/test_outgoing_badNumber.js
--- a/dom/telephony/test/marionette/manifest.ini
+++ b/dom/telephony/test/marionette/manifest.ini
@@ -7,17 +7,16 @@ qemu = true
 [test_incoming_answer_hangup.js]
 [test_incoming_reject.js]
 [test_outgoing_answer_hangup.js]
 [test_incoming_answer_hangup_oncallschanged.js]
 [test_outgoing_answer_hangup_oncallschanged.js]
 [test_outgoing_hangup_alerting.js]
 [test_outgoing_hangup_held.js]
 [test_outgoing_badNumber.js]
-disabled = Bug 761533
 [test_outgoing_busy.js]
 disabled = Bug 761533
 [test_outgoing_reject.js]
 [test_incoming_hold_resume.js]
 [test_outgoing_hold_resume.js]
 [test_incoming_already_connected.js]
 [test_incoming_answer_remote_hangup.js]
 [test_incoming_connecting_hangup.js]
--- a/dom/telephony/test/marionette/test_outgoing_badNumber.js
+++ b/dom/telephony/test/marionette/test_outgoing_badNumber.js
@@ -1,17 +1,17 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
 MARIONETTE_TIMEOUT = 10000;
 
 SpecialPowers.addPermission("telephony", true, document);
 
 let telephony = window.navigator.mozTelephony;
-let number = "not a valid phone number";
+let number = "****5555552368****";
 let outgoing;
 let calls;
 
 function verifyInitialState() {
   log("Verifying initial state.");
   ok(telephony);
   is(telephony.active, null);
   ok(telephony.calls);
@@ -33,26 +33,26 @@ function verifyInitialState() {
 function dial() {
   log("Make an outgoing call to an invalid number.");
 
   outgoing = telephony.dial(number);
   ok(outgoing);
   is(outgoing.number, number);
   is(outgoing.state, "dialing");
 
-  //is(outgoing, telephony.active); // bug 757587
-  //ok(telephony.calls === calls); // bug 757587
-  //is(calls.length, 1); // bug 757587
-  //is(calls[0], outgoing); // bug 757587
+  is(outgoing, telephony.active);
+  //ok(telephony.calls === calls); // bug 717414
+  is(telephony.calls.length, 1);
+  is(telephony.calls[0], outgoing);
 
   outgoing.onerror = function onerror(event) {
     log("Received 'error' event.");
     is(event.call, outgoing);
-    ok(call.error);
-    is(call.error.name, "BadNumberError");
+    ok(event.call.error);
+    is(event.call.error.name, "BadNumberError");
 
     runEmulatorCmd("gsm list", function(result) {
       log("Initial call list: " + result);
       is(result[0], "OK");
       cleanUp();
     });
   };
 }