Improve Valgrind suppressions for bug 793534 and bug 793549. DONTBUILD
authorJesse Ruderman <jruderman@gmail.com>
Mon, 24 Sep 2012 17:33:41 -0700
changeset 107959 29f6b5bfb0b45586a1d6159e20ade6fd92cfe8e0
parent 107958 cbd181aafd5ffadd602e5e0b586862d9b9cfec12
child 107960 13ae166abd45418394403a6f1f53c4dd53f0cd68
push id23524
push useremorley@mozilla.com
push dateTue, 25 Sep 2012 13:14:59 +0000
treeherdermozilla-central@7c7639f797d0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs793534, 793549
milestone18.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Improve Valgrind suppressions for bug 793534 and bug 793549. DONTBUILD
build/valgrind/i386-redhat-linux-gnu.sup
build/valgrind/x86_64-redhat-linux-gnu.sup
--- a/build/valgrind/i386-redhat-linux-gnu.sup
+++ b/build/valgrind/i386-redhat-linux-gnu.sup
@@ -1,25 +1,30 @@
 {
    Bug 793532
    Memcheck:Leak
    fun:malloc
    fun:_ZN8JSObject25allocateSlowArrayElementsEP9JSContext
    ...
 }
 {
-   This is intended, see bug 793534
+   PR_SetEnv requires its argument to be leaked, but does not appear on stacks. (See bug 793534 and see bug 793549.)
    Memcheck:Leak
-   fun:malloc
-   fun:strdup
-   fun:moz_strdup
+   ...
    fun:_ZL9SaveToEnvPKc
    ...
 }
 {
+   PR_SetEnv requires its argument to be leaked, but does not appear on stacks. (See bug 793534 and see bug 793549.)
+   Memcheck:Leak
+   ...
+   fun:_ZL13SaveWordToEnvPKcRK19nsACString_internal
+   ...
+}
+{
    Bug 793535
    Memcheck:Leak
    fun:calloc
    fun:_dlerror_run
    fun:dlsym
    fun:PR_SetCurrentThreadName
    ...
 }
@@ -50,16 +55,8 @@
    Memcheck:Leak
    fun:malloc
    fun:moz_xmalloc
    fun:NS_Alloc_P
    fun:_Z12ToNewCStringRK19nsACString_internal
    fun:_ZN13CrashReporter14SetupExtraDataEP7nsIFileRK19nsACString_internal
    ...
 }
-{
-   Bug 793549
-   Memcheck:Leak
-   fun:realloc
-   fun:PR_Realloc
-   fun:GrowStuff
-   ...
-}
--- a/build/valgrind/x86_64-redhat-linux-gnu.sup
+++ b/build/valgrind/x86_64-redhat-linux-gnu.sup
@@ -9,25 +9,30 @@
    Bug 793533
    Memcheck:Leak
    fun:malloc
    fun:moz_xmalloc
    fun:_Z22xpc_CreateGlobalObjectP9JSContextP7JSClassP12nsIPrincipalP11nsISupportsbPP8JSObjectPP13JSCompartment
    ...
 }
 {
-   This is intended, see bug 793534
+   PR_SetEnv requires its argument to be leaked, but does not appear on stacks. (See bug 793534 and see bug 793549.)
    Memcheck:Leak
-   fun:malloc
-   fun:strdup
-   fun:moz_strdup
+   ...
    fun:_ZL9SaveToEnvPKc
    ...
 }
 {
+   PR_SetEnv requires its argument to be leaked, but does not appear on stacks. (See bug 793534 and see bug 793549.)
+   Memcheck:Leak
+   ...
+   fun:_ZL13SaveWordToEnvPKcRK19nsACString_internal
+   ...
+}
+{
    Bug 793535
    Memcheck:Leak
    fun:calloc
    fun:_dlerror_run
    fun:dlsym
    fun:PR_SetCurrentThreadName
    ...
 }
@@ -59,24 +64,16 @@
    fun:malloc
    fun:moz_xmalloc
    fun:NS_Alloc_P
    fun:_Z12ToNewCStringRK19nsACString_internal
    fun:_ZN13CrashReporter14SetupExtraDataEP7nsIFileRK19nsACString_internal
    ...
 }
 {
-   Bug 793549
-   Memcheck:Leak
-   fun:realloc
-   fun:PR_Realloc
-   fun:GrowStuff
-   ...
-}
-{
    Bug 793598
    Memcheck:Leak
    fun:realloc
    ...
    obj:/lib64/libdbus-1.so.3.4.0
    ...
 }
 {