Bug 1528690 - P3 - Change more assertions to diagnostic assertion to get more information on Nightly; r=asuth
authorTom Tung <shes050117@gmail.com>
Tue, 23 Apr 2019 13:25:23 +0000
changeset 470490 2942b016522bf1457bd8d9264c72f80be43e66f2
parent 470489 66fe93fc552c537916e311e8dfc61bb90fbb8132
child 470491 c9e17214f445d48114913ea9f0c00f334edac55a
push id35906
push useraciure@mozilla.com
push dateTue, 23 Apr 2019 22:14:56 +0000
treeherdermozilla-central@0ce3633f8b80 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs1528690
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528690 - P3 - Change more assertions to diagnostic assertion to get more information on Nightly; r=asuth Differential Revision: https://phabricator.services.mozilla.com/D28455
dom/indexedDB/ActorsParent.cpp
--- a/dom/indexedDB/ActorsParent.cpp
+++ b/dom/indexedDB/ActorsParent.cpp
@@ -9283,17 +9283,17 @@ DatabaseConnection::DatabaseConnection(
   MOZ_ASSERT(aFileManager);
 }
 
 DatabaseConnection::~DatabaseConnection() {
   MOZ_ASSERT(!mStorageConnection);
   MOZ_ASSERT(!mFileManager);
   MOZ_ASSERT(!mCachedStatements.Count());
   MOZ_ASSERT(!mUpdateRefcountFunction);
-  MOZ_ASSERT(!mInWriteTransaction);
+  MOZ_DIAGNOSTIC_ASSERT(!mInWriteTransaction);
   MOZ_ASSERT(!mDEBUGSavepointCount);
 }
 
 nsresult DatabaseConnection::Init() {
   AssertIsOnConnectionThread();
   MOZ_ASSERT(!mInReadTransaction);
   MOZ_ASSERT(!mInWriteTransaction);
 
@@ -9850,17 +9850,17 @@ nsresult DatabaseConnection::GetFreelist
   *aFreelistCount = uint32_t(freelistCount);
   return NS_OK;
 }
 
 void DatabaseConnection::Close() {
   AssertIsOnConnectionThread();
   MOZ_ASSERT(mStorageConnection);
   MOZ_ASSERT(!mDEBUGSavepointCount);
-  MOZ_ASSERT(!mInWriteTransaction);
+  MOZ_DIAGNOSTIC_ASSERT(!mInWriteTransaction);
 
   AUTO_PROFILER_LABEL("DatabaseConnection::Close", DOM);
 
   if (mUpdateRefcountFunction) {
     MOZ_ALWAYS_SUCCEEDS(mStorageConnection->RemoveFunction(
         NS_LITERAL_CSTRING("update_refcount")));
     mUpdateRefcountFunction = nullptr;
   }