bug 1523104: remote: disconnect from build system; r=me
authorAndreas Tolfsen <ato@sny.no>
Fri, 08 Mar 2019 14:10:11 +0000
changeset 463264 2932c11d19a575880474f01a6862813708697d25
parent 463263 25dd3f1e01c9531f272a1c5a51f5a027523dcd23
child 463265 24b9ae45e4fa180165e73769584d0921a495a8bc
push id35669
push userbtara@mozilla.com
push dateFri, 08 Mar 2019 21:53:37 +0000
treeherdermozilla-central@67424fa758d4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1523104
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1523104: remote: disconnect from build system; r=me We need a build peers' approval for hooking the remote agent up to the build system.
browser/installer/package-manifest.in
toolkit/moz.configure
toolkit/toolkit.mozbuild
--- a/browser/installer/package-manifest.in
+++ b/browser/installer/package-manifest.in
@@ -178,24 +178,17 @@
 #endif
 @RESPATH@/components/SyncComponents.manifest
 @RESPATH@/components/servicesComponents.manifest
 @RESPATH@/components/servicesSettings.manifest
 @RESPATH@/components/cryptoComponents.manifest
 
 @RESPATH@/components/Push.manifest
 
-; CDP remote agent
-#ifdef ENABLE_REMOTE_AGENT
-@RESPATH@/components/RemoteAgent.js
-@RESPATH@/components/RemoteAgent.manifest
-@RESPATH@/defaults/pref/remote.js
-#endif
-
-; Marionette remote control protocol
+; Remote control protocol
 #ifdef ENABLE_MARIONETTE
 @RESPATH@/chrome/marionette@JAREXT@
 @RESPATH@/chrome/marionette.manifest
 @RESPATH@/components/marionette.manifest
 @RESPATH@/components/marionette.js
 @RESPATH@/defaults/pref/marionette.js
 #endif
 
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -898,32 +898,16 @@ def ft2_info(freetype2_combined_info, tr
         return freetype2_combined_info
 
 set_config('FT2_LIBS', ft2_info.libs)
 add_old_configure_assignment('FT2_LIBS',
                              ft2_info.libs)
 add_old_configure_assignment('FT2_CFLAGS',
                              ft2_info.cflags)
 
-
-# CDP remote agent
-# ==============================================================
-#
-# The source code lives under ../remote.
-
-option('--enable-cdp', help='Enable CDP-based remote agent')
-
-@depends('--enable-cdp')
-def remote(value):
-    if value:
-        return True
-
-set_config('ENABLE_REMOTE_AGENT', remote)
-
-
 # Marionette remote protocol
 # ==============================================================
 #
 # Marionette is the Gecko remote protocol used for various remote control,
 # automation, and testing purposes throughout Gecko, Firefox, and Fennec.
 # Marionette lives in ../testing/marionette.
 #
 # Marionette is not really a toolkit feature, as much as a Gecko engine
@@ -949,17 +933,16 @@ option('--enable-marionette',
 
 @depends('--enable-marionette')
 def marionette(value):
     if value:
         return True
 
 set_config('ENABLE_MARIONETTE', marionette)
 
-
 # geckodriver WebDriver implementation
 # ==============================================================
 #
 # Turn off geckodriver for build configs we don't handle yet,
 # but allow --enable-geckodriver to override when compile environment is available.
 # --disable-tests implies disabling geckodriver.
 
 @depends('--enable-tests', target, cross_compiling, hazard_analysis, asan)
@@ -979,17 +962,16 @@ option('--enable-geckodriver', default=g
 
 @depends('--enable-geckodriver', when='--enable-compile-environment')
 def geckodriver(enabled):
     if enabled:
         return True
 
 set_config('ENABLE_GECKODRIVER', geckodriver)
 
-
 # WebRTC
 # ========================================================
 @depends(target)
 def webrtc_default(target):
     # Turn off webrtc for OS's we don't handle yet, but allow
     # --enable-webrtc to override.
     os_match = False
     for os_fragment in ('linux', 'mingw', 'android', 'linuxandroid',
--- a/toolkit/toolkit.mozbuild
+++ b/toolkit/toolkit.mozbuild
@@ -156,19 +156,16 @@ DIRS += [
     '/other-licenses/snappy',
 ]
 
 if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']:
     DIRS += [
         '/toolkit/system/gnome',
     ]
 
-if CONFIG['ENABLE_REMOTE_AGENT']:
-    DIRS += ['/remote']
-
 if CONFIG['ENABLE_MARIONETTE']:
     DIRS += [
         '/testing/firefox-ui',
         '/testing/marionette',
     ]
 
 if CONFIG['ENABLE_GECKODRIVER'] and not CONFIG['MOZ_TSAN']:
     DIRS += ['/testing/geckodriver']