Bug 1184959 part 1 - check_macroassembler_style: Only add an inline prefix in the output, if the methods are inlined. r=h4writer
authorNicolas B. Pierron <nicolas.b.pierron@mozilla.com>
Mon, 17 Aug 2015 11:32:15 +0200
changeset 258025 28c84f5978dae7e26dad0fee66b96646241d928d
parent 258024 7c96ee5b37f3c1f2d97f08644557bc3b8fa15e3c
child 258026 011f8d81a9ae1e11e09bd46916cdca9c433cb779
push id29241
push userkwierso@gmail.com
push dateTue, 18 Aug 2015 00:00:46 +0000
treeherdermozilla-central@6ae3e9ff53b2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersh4writer
bugs1184959
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1184959 part 1 - check_macroassembler_style: Only add an inline prefix in the output, if the methods are inlined. r=h4writer
config/check_macroassembler_style.py
--- a/config/check_macroassembler_style.py
+++ b/config/check_macroassembler_style.py
@@ -76,21 +76,26 @@ def get_normalized_signatures(signature,
     inline = False
     if fileAnnot:
         inline = fileAnnot['inline']
 
     if 'inline ' in signature:
         signature = re.sub(r'inline\s+', '', signature)
         inline = True
 
-    return [
-        { 'arch': a, 'sig': 'inline ' + signature }
+    inlinePrefx = ''
+    if inline:
+        inlinePrefx = 'inline '
+    signatures =  [
+        { 'arch': a, 'sig': inlinePrefx + signature }
         for a in archs
     ]
 
+    return signatures
+
 file_suffixes = set([
     a.replace('_', '-') for a in
     all_architecture_names.union(all_shared_architecture_names)
 ])
 def get_file_annotation(filename):
     origFilename = filename
     filename = filename.split('/')[-1]