Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r=gijs
authorJared Wein <jwein@mozilla.com>
Wed, 01 Jun 2016 15:34:47 -0400
changeset 300344 28b383d15b1ade1b36f56beaeadc0eecf26b15de
parent 300343 10371d73bb08fa730e311885433bd147bf2a3576
child 300345 f7b224e544f8a8f163b2792bee6cba2a1c591716
push id30312
push usercbook@mozilla.com
push dateMon, 06 Jun 2016 09:55:12 +0000
treeherdermozilla-central@c37d634eba0d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgijs
bugs1251134
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r=gijs MozReview-Commit-ID: L46711lTbPC
browser/base/content/test/general/browser_bookmark_popup.js
--- a/browser/base/content/test/general/browser_bookmark_popup.js
+++ b/browser/base/content/test/general/browser_bookmark_popup.js
@@ -37,17 +37,16 @@ function* test_bookmarks_popup({isNewBoo
 
     if (popupEditFn) {
       yield popupEditFn();
     }
     let bookmarks = [];
     yield PlacesUtils.bookmarks.fetch({url: "about:home"}, bm => bookmarks.push(bm));
     is(bookmarks.length, 1, "Only one bookmark should exist");
     is(bookmarkStar.getAttribute("starred"), "true", "Page is starred");
-    is(bookmarkPanel.state, "open", "Check that panel state is 'open'");
     is(bookmarkPanelTitle.value,
       isNewBookmark ?
         gNavigatorBundle.getString("editBookmarkPanel.pageBookmarkedTitle") :
         gNavigatorBundle.getString("editBookmarkPanel.editBookmarkTitle"),
       "title should match isEditingBookmark state");
 
     if (!shouldAutoClose) {
       yield new Promise(resolve => setTimeout(resolve, 400));