Bug 1556567 - Use custom `geckodriver` with pre-release Android support in `mach browsertime`. r=sefeng
authorNick Alexander <nalexander@mozilla.com>
Tue, 18 Jun 2019 22:44:52 +0000
changeset 479220 289805d6054ddc04c5d687353a9237f2874db550
parent 479219 382f21591267f9563a043c24db8a7e9936ea0bb0
child 479221 ddbad8f00d6121a64802e7890b5f81986899320f
push id36174
push useropoprus@mozilla.com
push dateWed, 19 Jun 2019 21:38:13 +0000
treeherdermozilla-central@5b9a3de04646 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssefeng
bugs1556567
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1556567 - Use custom `geckodriver` with pre-release Android support in `mach browsertime`. r=sefeng Differential Revision: https://phabricator.services.mozilla.com/D33574
tools/browsertime/mach_commands.py
--- a/tools/browsertime/mach_commands.py
+++ b/tools/browsertime/mach_commands.py
@@ -170,16 +170,21 @@ class MachBrowsertime(MachCommandBase):
                     unpack_file(archive)
                 finally:
                     os.chdir(cwd)
 
         # Install the browsertime Node.js requirements.
         if not setup_helper.check_node_executables_valid():
             return 1
 
+        if 'GECKODRIVER_BASE_URL' not in os.environ:
+            # Use custom `geckodriver` with pre-release Android support.
+            url = 'https://github.com/ncalexan/geckodriver/releases/download/v0.24.0-android/'
+            os.environ['GECKODRIVER_BASE_URL'] = url
+
         self.log(
             logging.INFO,
             'browsertime',
             {'package_json': mozpath.join(BROWSERTIME_ROOT, 'package.json')},
             'Installing browsertime node module from {package_json}')
         status = setup_helper.package_setup(
             BROWSERTIME_ROOT,
             'browsertime',