Bug 1731564: Use motivated SpinEventLoopUntil inside devtools/*. r=devtools-reviewers,jdescottes
☠☠ backed out by 01794374c42c ☠ ☠
authorJens Stutte <jstutte@mozilla.com>
Wed, 06 Oct 2021 19:45:12 +0000
changeset 594964 283c5393cbbcfe0bd792f0f58325df536b1a1fa6
parent 594963 317bc38e3de5f803895ef30fbb60211d75897bc5
child 594965 d8071cc32bd98b185b0d867ed10e98b5621e9417
push id38855
push usernbeleuzu@mozilla.com
push dateThu, 07 Oct 2021 03:26:29 +0000
treeherdermozilla-central@01794374c42c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdevtools-reviewers, jdescottes
bugs1731564
milestone95.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1731564: Use motivated SpinEventLoopUntil inside devtools/*. r=devtools-reviewers,jdescottes Depends on D126957 Differential Revision: https://phabricator.services.mozilla.com/D127099
devtools/platform/nsJSInspector.cpp
--- a/devtools/platform/nsJSInspector.cpp
+++ b/devtools/platform/nsJSInspector.cpp
@@ -66,17 +66,18 @@ nsJSInspector::EnterNestedEventLoop(JS::
 
   mLastRequestor = requestor;
   mRequestors.AppendElement(requestor);
   mozilla::HoldJSObjects(this);
 
   mozilla::dom::AutoNoJSAPI nojsapi;
 
   uint32_t nestLevel = ++mNestedLoopLevel;
-  if (!SpinEventLoopUntil([&]() { return mNestedLoopLevel < nestLevel; })) {
+  if (!SpinEventLoopUntil("nsJSInspector::EnterNestedEventLoop"_ns,
+                          [&]() { return mNestedLoopLevel < nestLevel; })) {
     rv = NS_ERROR_UNEXPECTED;
   }
 
   NS_ASSERTION(mNestedLoopLevel <= nestLevel,
                "nested event didn't unwind properly");
 
   if (mNestedLoopLevel == nestLevel) {
     mLastRequestor = mRequestors.ElementAt(--mNestedLoopLevel);