Bug 1494894 - sidebar CSS: use color instead of opacity for unselectable items;r=ladybenko
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 26 Oct 2018 15:00:13 +0000
changeset 443153 2812a46d115d5b7e4eceb0285f3848d2544a362d
parent 443152 ba1fcb7618efc99f927339eb10e818aaebbe11bf
child 443154 385fec55c19a9bbd13f6fd1fe9e43bddb0658d36
push id34942
push usercsabou@mozilla.com
push dateFri, 26 Oct 2018 21:55:19 +0000
treeherdermozilla-central@cffa05ba11d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersladybenko
bugs1494894
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1494894 - sidebar CSS: use color instead of opacity for unselectable items;r=ladybenko Depends on D9652 This allows the Connect button to no longer look disabled. However we could maybe mutualize colors a bit more, either with a --color-disabled variable or with a class. Differential Revision: https://phabricator.services.mozilla.com/D9653
devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.css
--- a/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.css
+++ b/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.css
@@ -13,17 +13,17 @@
   border-radius: 2px;
   padding-inline-end: 10px;
   padding-inline-start: 10px;
   transition: background-color 150ms;
   -moz-user-select: none;
 }
 
 .sidebar-item:not(.sidebar-item--selectable) {
-  opacity: 0.5;
+  color: var(--grey-40);
 }
 
 .sidebar-item--selectable:hover {
   background-color: var(--sidebar-background-hover);
 }
 
 .sidebar-item--selected {
   color: var(--sidebar-selected-color);