Bug 1531357 [wpt PR 15509] - [LayoutNG] Fix 3 cases of break opportunities after nowrap, a=testonly
authorKoji Ishii <kojii@chromium.org>
Wed, 06 Mar 2019 16:52:40 +0000
changeset 464684 272d41054b82400e7fc7109f087da3374f767001
parent 464683 68f70e376346e070ab27bcf97ad8db71c02fa087
child 464685 45cdd214896fd95f324f5e3daf785d0e8da9ced9
push id35717
push useraciure@mozilla.com
push dateSun, 17 Mar 2019 09:45:26 +0000
treeherdermozilla-central@e0861be8d6c0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1531357, 15509, 920177, 1477629, 635180
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1531357 [wpt PR 15509] - [LayoutNG] Fix 3 cases of break opportunities after nowrap, a=testonly Automatic update from web-platform-tests [LayoutNG] Fix 3 cases of break opportunities after nowrap This patch fixes lines to break in the following conditions: 1. When wrappable elements appear inside of nowrap elements. 2. When wrappable spaces after nowrap appear inside of nowrap elements. 3. When non-space break opportunities appear after nowrap. fast/text/whitespace/018.html improves but still doesn't pass. It doesn't pass in Edge/Gecko, and at least some of what it expects look questionable. Further investigation is deferred to future CLs. Bug: 920177 Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995 Reviewed-on: https://chromium-review.googlesource.com/c/1477629 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635180} -- wpt-commits: 67e1c4c4f8a43d17bcf89b6f5a197d21765f4b46 wpt-pr: 15509
testing/web-platform/tests/css/css-text/white-space/reference/white-space-wrap-after-nowrap-001-ref.html
testing/web-platform/tests/css/css-text/white-space/white-space-wrap-after-nowrap-001.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-text/white-space/reference/white-space-wrap-after-nowrap-001-ref.html
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<style>
+div {
+  width: 10ch;
+  border: 2px solid blue;
+  line-height: 1;
+}
+.ideo > div {
+  width: 1em;
+}
+</style>
+<body>
+  <section>
+    <div>12345<br>67890</div>
+    <div>12345<br>67890</div>
+    <div>12345<br>67890</div>
+    <div>12345<br>67890</div>
+
+    <div>12345<br>67890</div>
+    <div>12345<br>67890</div>
+  </section>
+
+  <section class="ideo">
+    <div>国<br>国</div>
+    <div>国<br>国</div>
+    <div>国<br>国</div>
+    <div>国<br>国</div>
+  </section>
+</body>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-text/white-space/white-space-wrap-after-nowrap-001.html
@@ -0,0 +1,41 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>Break opportunities after nowrap</title>
+<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
+<link rel="help" href="https://drafts.csswg.org/css-text-3/#white-space-property">
+<link rel="match" href="reference/white-space-wrap-after-nowrap-001-ref.html">
+<meta name="assert" content="This test ensures that break opportunities after nowrap can break lines.">
+<style>
+div {
+  width: 10ch;
+  border: 2px solid blue;
+  line-height: 1;
+}
+.ideo > div {
+  width: 1em;
+}
+.normal {
+  white-space: normal;
+}
+.nowrap {
+  white-space: nowrap;
+}
+</style>
+<body>
+  <section>
+    <div><span class="nowrap">12345</span> 67890</div>
+    <div><span class="nowrap">12345</span><span class="normal"> 67890</span></div>
+    <div><span class="nowrap">12345<span class="normal"> 67890</span></span></div>
+    <div class="nowrap">12345<span class="normal"> 67890</span></div>
+
+    <div class="nowrap"><span class="normal"><span class="nowrap">12345</span> </span>67890</div>
+    <div class="nowrap"><span class="normal"><span class="nowrap">12345 </span> </span>67890</div>
+  </section>
+
+  <section class="ideo">
+    <div><span class="nowrap">国</span>国</div>
+    <div><span class="nowrap">国</span><span class="normal">国</span></div>
+    <div><span class="nowrap">国<span class="normal">国</span></span></div>
+    <div class="nowrap">国<span class="normal">国</span></div>
+  </section>
+</body>