Bug 1573725: turn on the pref for text-decoration-thickness on by default (in early-beta and earlier) r=dholbert
authorCharlie Marlow <cmarlow@mozilla.com>
Wed, 14 Aug 2019 16:46:18 +0000
changeset 487989 27209bcee14fe4bdbfb87c1f128035b3d1cb7f96
parent 487988 3f93f3c645b92d2cec2137f831f555eeab79360f
child 487990 9ae108bb86e2c93d9d74f43cfa8f39a9e84cc8b2
push id36434
push usercbrindusan@mozilla.com
push dateThu, 15 Aug 2019 09:44:30 +0000
treeherdermozilla-central@144fbfb409b7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1573725
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573725: turn on the pref for text-decoration-thickness on by default (in early-beta and earlier) r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D41883
devtools/shared/css/generated/properties-db.js
modules/libpref/init/StaticPrefList.yaml
testing/web-platform/tests/css/css-text-decor/parsing/text-decoration-invalid.html
--- a/devtools/shared/css/generated/properties-db.js
+++ b/devtools/shared/css/generated/properties-db.js
@@ -9984,16 +9984,30 @@ exports.CSS_PROPERTIES = {
       "inherit",
       "initial",
       "revert",
       "solid",
       "unset",
       "wavy"
     ]
   },
+  "text-decoration-thickness": {
+    "isInherited": false,
+    "subproperties": [
+      "text-decoration-thickness"
+    ],
+    "supports": [],
+    "values": [
+      "auto",
+      "inherit",
+      "initial",
+      "revert",
+      "unset"
+    ]
+  },
   "text-emphasis": {
     "isInherited": true,
     "subproperties": [
       "text-emphasis-style",
       "text-emphasis-color"
     ],
     "supports": [
       "color"
--- a/modules/libpref/init/StaticPrefList.yaml
+++ b/modules/libpref/init/StaticPrefList.yaml
@@ -4057,17 +4057,17 @@
 - name: layout.css.text-underline-offset.enabled
   type: bool
   value: @IS_EARLY_BETA_OR_EARLIER@
   mirror: always
 
 # text decoration thickness
 - name: layout.css.text-decoration-thickness.enabled
   type: bool
-  value: false
+  value: @IS_EARLY_BETA_OR_EARLIER@
   mirror: always
 
 # text decoration skip ink
 - name: layout.css.text-decoration-skip-ink.enabled
   type: bool
   value: false
   mirror: always
 
--- a/testing/web-platform/tests/css/css-text-decor/parsing/text-decoration-invalid.html
+++ b/testing/web-platform/tests/css/css-text-decor/parsing/text-decoration-invalid.html
@@ -2,15 +2,12 @@
 <meta charset="utf-8">
 <title>CSS Text Decoration Test: Parsing text-decoration with invalid values</title>
 <link rel="help" href="https://drafts.csswg.org/css-text-decor-3/#propdef-text-decoration">
 <meta name="assert" content="text-decoration supports only the grammar '<‘text-decoration-line’> || <‘text-decoration-style’> || <‘text-decoration-color’>'.">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script src="/css/support/parsing-testcommon.js"></script>
 <script>
-test_invalid_value("text-decoration", "auto");
-test_invalid_value("text-decoration", "1px");
-
 test_invalid_value("text-decoration", "double overline underline dotted");
 test_invalid_value("text-decoration", "red line-through green");
 test_invalid_value("text-decoration", "overline blue underline");
 </script>