Bug 1528266 [wpt PR 15413] - Simplify test_driver_internal to not use prototype + Object.create, a=testonly
authorPhilip Jägenstedt <philip@foolip.org>
Tue, 05 Mar 2019 12:17:38 +0000
changeset 464569 26d55c6031ffe95018cbc5dd37dea0579b589d2c
parent 464568 db90080867414585fb1baf9ad8974be98850b119
child 464570 872d7defb5d40de2d006e27516d237ad1f0594cb
push id35717
push useraciure@mozilla.com
push dateSun, 17 Mar 2019 09:45:26 +0000
treeherdermozilla-central@e0861be8d6c0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1528266, 15413, 11173
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528266 [wpt PR 15413] - Simplify test_driver_internal to not use prototype + Object.create, a=testonly Automatic update from web-platform-tests Simplify test_driver_internal to not use prototype + Object.create (#15413) Context: https://github.com/web-platform-tests/wpt/pull/11173/files#r236038149 -- wpt-commits: 83e8b970efc66feed5fde392d80209ea6540a283 wpt-pr: 15413
testing/web-platform/tests/resources/testdriver.js
--- a/testing/web-platform/tests/resources/testdriver.js
+++ b/testing/web-platform/tests/resources/testdriver.js
@@ -192,17 +192,17 @@
          * @returns {Promise} fufiled after the actions are performed, or rejected in
          *                    the cases the WebDriver command errors
          */
         action_sequence: function(actions) {
             return window.test_driver_internal.action_sequence(actions);
         }
     };
 
-    var manual = {
+    window.test_driver_internal = {
         /**
          * This flag should be set to `true` by any code which implements the
          * internal methods defined below for automation purposes. Doing so
          * allows the library to signal failure immediately when an automated
          * implementation of one of the methods is not available.
          */
         in_automation: false,
 
@@ -278,12 +278,9 @@
          *
          * @returns {Promise} fufilled after actions are sent, rejected if any actions
          *                    fail
          */
         action_sequence: function(actions) {
             return Promise.reject(new Error("unimplemented"));
         }
     };
-
-    window.test_driver_internal = Object.create(manual);
-
 })();