Bug 906166. Make sure to initialize the "succeeded" outparam of XPC_WN_Helper_DelProperty. r=bholley
authorBoris Zbarsky <bzbarsky@mit.edu>
Mon, 30 Sep 2013 10:31:30 -0400
changeset 149274 26cdc56bad7d22331c167bbf94b68d7fc6deb978
parent 149273 2c7230203ec219434acc19bc5c4d9a09369da4ce
child 149275 ab4c0533cff419ac6362f9d6fd66a64e54f53e01
push id25380
push userryanvm@gmail.com
push dateMon, 30 Sep 2013 20:16:36 +0000
treeherdermozilla-central@1332fc1c15e1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbholley
bugs906166
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 906166. Make sure to initialize the "succeeded" outparam of XPC_WN_Helper_DelProperty. r=bholley
js/xpconnect/src/XPCWrappedNativeJSOps.cpp
--- a/js/xpconnect/src/XPCWrappedNativeJSOps.cpp
+++ b/js/xpconnect/src/XPCWrappedNativeJSOps.cpp
@@ -807,16 +807,17 @@ XPC_WN_Helper_AddProperty(JSContext *cx,
     AddProperty(wrapper, cx, obj, id, vp.address(), &retval);
     POST_HELPER_STUB
 }
 
 static bool
 XPC_WN_Helper_DelProperty(JSContext *cx, HandleObject obj, HandleId id,
                           bool *succeeded)
 {
+    *succeeded = true;
     PRE_HELPER_STUB
     DelProperty(wrapper, cx, obj, id, &retval);
     POST_HELPER_STUB
 }
 
 bool
 XPC_WN_Helper_GetProperty(JSContext *cx, HandleObject obj, HandleId id,
                           MutableHandleValue vp)