Bug 1177822 - The button "Start Recording Performance" is misplaced after some actions (always reproducible), r=jsantell
authorVictor Porof <vporof@mozilla.com>
Mon, 21 Mar 2016 10:05:12 +0100
changeset 289573 26a0c274e9caeeb87fff29966bf829ba1a6ced9a
parent 289572 e2c0da4fea784d79079dccc7bb10a9d0b15be9a2
child 289574 1ace0d75f8b7bc2d8fccca13cca33966e7464ca0
push id30107
push usercbook@mozilla.com
push dateTue, 22 Mar 2016 10:00:23 +0000
treeherdermozilla-central@3587b25bae30 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjsantell
bugs1177822
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1177822 - The button "Start Recording Performance" is misplaced after some actions (always reproducible), r=jsantell
devtools/client/performance/performance-view.js
--- a/devtools/client/performance/performance-view.js
+++ b/devtools/client/performance/performance-view.js
@@ -15,35 +15,41 @@ var PerformanceView = {
   // that the server has support for determining buffer status.
   _bufferStatusSupported: false,
 
   // Mapping of state to selectors for different properties and their values,
   // from the main profiler view. Used in `PerformanceView.setState()`
   states: {
     "unavailable": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#unavailable-notice") },
+      { sel: "#performance-view-content", opt: "hidden", val: () => true },
     ],
     "empty": [
-      { sel: "#performance-view", opt: "selectedPanel", val: () => $("#empty-notice") }
+      { sel: "#performance-view", opt: "selectedPanel", val: () => $("#empty-notice") },
+      { sel: "#performance-view-content", opt: "hidden", val: () => true },
     ],
     "recording": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#recording-notice") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#recording-notice") },
     ],
     "console-recording": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#console-recording-notice") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#console-recording-notice") },
     ],
     "recorded": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#details-pane") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#details-pane") },
     ],
     "loading": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#loading-notice") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#loading-notice") },
     ]
   },
 
   /**
    * Sets up the view with event binding and main subviews.
    */
   initialize: Task.async(function* () {
     this._recordButton = $("#main-record-button");