Bug 1287383 - Support style="" attributes longer than 255 characters when using the Servo style backend. r=emilio
authorCameron McCormack <cam@mcc.id.au>
Mon, 18 Jul 2016 16:36:59 +0800
changeset 305438 25b1668437272613a868182e7255852481940f16
parent 305437 9edae2531988223eb282ec0995eb736fd0fb8762
child 305439 0ce39c20b7063e84b1f942a971af1ccf912915ee
push id30463
push usercbook@mozilla.com
push dateTue, 19 Jul 2016 14:02:45 +0000
treeherdermozilla-central@37cc0da01187 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1287383
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1287383 - Support style="" attributes longer than 255 characters when using the Servo style backend. r=emilio MozReview-Commit-ID: 9o5Go7lnAhG
layout/style/ServoBindings.cpp
layout/style/ServoBindings.h
--- a/layout/style/ServoBindings.cpp
+++ b/layout/style/ServoBindings.cpp
@@ -679,17 +679,17 @@ Servo_InitStyleSet()
 void
 Servo_DropStyleSet(RawServoStyleSet* set)
 {
   MOZ_CRASH("stylo: shouldn't be calling Servo_DropStyleSet in a "
             "non-MOZ_STYLO build");
 }
 
 ServoDeclarationBlock*
-Servo_ParseStyleAttribute(const uint8_t* bytes, uint8_t length,
+Servo_ParseStyleAttribute(const uint8_t* bytes, uint32_t length,
                           nsHTMLCSSStyleSheet* cache)
 {
   MOZ_CRASH("stylo: shouldn't be calling Servo_ParseStyleAttribute in a "
             "non-MOZ_STYLO build");
 }
 
 void
 Servo_DropDeclarationBlock(ServoDeclarationBlock* declarations)
--- a/layout/style/ServoBindings.h
+++ b/layout/style/ServoBindings.h
@@ -212,17 +212,17 @@ void Servo_InsertStyleSheetBefore(RawSer
                                   RawServoStyleSheet* reference,
                                   RawServoStyleSet* set);
 bool Servo_StyleSheetHasRules(RawServoStyleSheet* sheet);
 RawServoStyleSet* Servo_InitStyleSet();
 void Servo_DropStyleSet(RawServoStyleSet* set);
 
 // Style attributes.
 ServoDeclarationBlock* Servo_ParseStyleAttribute(const uint8_t* bytes,
-                                                 uint8_t length,
+                                                 uint32_t length,
                                                  nsHTMLCSSStyleSheet* cache);
 void Servo_DropDeclarationBlock(ServoDeclarationBlock* declarations);
 nsHTMLCSSStyleSheet* Servo_GetDeclarationBlockCache(
     ServoDeclarationBlock* declarations);
 void Servo_SetDeclarationBlockImmutable(ServoDeclarationBlock* declarations);
 void Servo_ClearDeclarationBlockCachePointer(ServoDeclarationBlock* declarations);
 
 // Computed style data.