Bug 1521879 - Part 6: Disable SetProxyServer for the IPC implementation until bug 1521113 is fixed or worked around. r=mjf
authorByron Campen [:bwc] <docfaraday@gmail.com>
Mon, 25 Feb 2019 21:52:01 +0000
changeset 461004 259d00c5c42b830a5983ee65acfa9cc9c04fe6c5
parent 461003 5c091f2ad086fbe0baf1a8cb6e13754ced45e387
child 461005 634949dfc7926a1c295b08fdd015ca13b57d3113
push id35613
push usernerli@mozilla.com
push dateTue, 26 Feb 2019 03:52:35 +0000
treeherdermozilla-central@faec87a80ed1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmjf
bugs1521879, 1521113
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521879 - Part 6: Disable SetProxyServer for the IPC implementation until bug 1521113 is fixed or worked around. r=mjf Differential Revision: https://phabricator.services.mozilla.com/D17560
media/webrtc/signaling/src/peerconnection/MediaTransportHandlerIPC.cpp
--- a/media/webrtc/signaling/src/peerconnection/MediaTransportHandlerIPC.cpp
+++ b/media/webrtc/signaling/src/peerconnection/MediaTransportHandlerIPC.cpp
@@ -142,26 +142,29 @@ void MediaTransportHandlerIPC::Destroy()
       },
       [](const nsCString& aError) {});
 }
 
 // We will probably be able to move the proxy lookup stuff into
 // this class once we move mtransport to its own process.
 void MediaTransportHandlerIPC::SetProxyServer(
     NrSocketProxyConfig&& aProxyConfig) {
+  // TODO(bug 1521113): This doesn't work on IPC
+#if 0
   mInitPromise->Then(
       GetMainThreadSerialEventTarget(), __func__,
       [aProxyConfig = std::move(aProxyConfig), this,
        self = RefPtr<MediaTransportHandlerIPC>(this)](bool /*dummy*/) mutable {
         if (mChild) {
           mChild->SendSetProxyServer(aProxyConfig.GetBrowser(),
                                      aProxyConfig.GetAlpn());
         }
       },
       [](const nsCString& aError) {});
+#endif
 }
 
 void MediaTransportHandlerIPC::EnsureProvisionalTransport(
     const std::string& aTransportId, const std::string& aLocalUfrag,
     const std::string& aLocalPwd, size_t aComponentCount) {
   mInitPromise->Then(
       GetMainThreadSerialEventTarget(), __func__,
       [=, self = RefPtr<MediaTransportHandlerIPC>(this)](bool /*dummy*/) {