Bug 1609144 - Remove IsInProcess assertion in NotifyContentBlockingEvent r=timhuang
authorDimi Lee <dlee@mozilla.com>
Thu, 16 Jan 2020 05:30:44 +0000
changeset 510438 259b0925375efedccee0c478ac90bf6c78ff3618
parent 510437 f41766fb940707b210530250d9017acca09ca40f
child 510439 572928224d2df10c447e9af20d961702df474d12
push id37021
push userrmaries@mozilla.com
push dateThu, 16 Jan 2020 09:46:51 +0000
treeherdermozilla-central@7541d616ff87 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstimhuang
bugs1609144
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1609144 - Remove IsInProcess assertion in NotifyContentBlockingEvent r=timhuang The assertion is added to diagnose whether NotifyContentBlockingEvent will be called from an in-process document. We have already seen crashes because of the assertion, so temporarily remove this to avoid people keep crashing due to this. Differential Revision: https://phabricator.services.mozilla.com/D60002
dom/ipc/WindowGlobalParent.cpp
--- a/dom/ipc/WindowGlobalParent.cpp
+++ b/dom/ipc/WindowGlobalParent.cpp
@@ -311,17 +311,18 @@ void WindowGlobalParent::NotifyContentBl
   MOZ_ASSERT(aURIHint);
   DebugOnly<bool> isCookiesBlockedTracker =
       aEvent == nsIWebProgressListener::STATE_COOKIES_BLOCKED_TRACKER ||
       aEvent == nsIWebProgressListener::STATE_COOKIES_BLOCKED_SOCIALTRACKER;
   MOZ_ASSERT_IF(aBlocked, aReason.isNothing());
   MOZ_ASSERT_IF(!isCookiesBlockedTracker, aReason.isNothing());
   MOZ_ASSERT_IF(isCookiesBlockedTracker && !aBlocked, aReason.isSome());
   MOZ_DIAGNOSTIC_ASSERT(XRE_IsParentProcess());
-  MOZ_DIAGNOSTIC_ASSERT_IF(XRE_IsE10sParentProcess(), !IsInProcess());
+  // TODO: temporarily remove this until we find the root case of Bug 1609144
+  //MOZ_DIAGNOSTIC_ASSERT_IF(XRE_IsE10sParentProcess(), !IsInProcess());
 
   // Return early if this WindowGlobalParent is in process.
   if (IsInProcess()) {
     return;
   }
 
   nsAutoCString origin;
   nsContentUtils::GetASCIIOrigin(aURIHint, origin);