Bug 914478 - Fix checking for error in setElemTryCache. (r=jandem)
authorShu-yu Guo <shu@rfrn.org>
Tue, 10 Sep 2013 04:15:55 -0700
changeset 146408 255093e2f430a62554a139327f479c5e9cbc9ce4
parent 146407 4ab57d0318fff7d71ac795724939b6faeccf16a8
child 146409 19918a47a06f299b8a47f983db0eedde1d535c5e
push id25260
push userryanvm@gmail.com
push dateWed, 11 Sep 2013 00:29:30 +0000
treeherdermozilla-central@f73bed2856a8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs914478
milestone26.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 914478 - Fix checking for error in setElemTryCache. (r=jandem)
js/src/jit/IonBuilder.cpp
--- a/js/src/jit/IonBuilder.cpp
+++ b/js/src/jit/IonBuilder.cpp
@@ -7265,18 +7265,18 @@ IonBuilder::setElemTryCache(bool *emitte
     // TODO: Bug 876650: remove this check:
     // Temporary disable the cache if non dense native,
     // until the cache supports more ics
     SetElemICInspector icInspect(inspector->setElemICInspector(pc));
     if (!icInspect.sawDenseWrite() && !icInspect.sawTypedArrayWrite())
         return true;
 
     bool needsBarrier;
-    if (PropertyWriteNeedsTypeBarrier(cx, current, &object, NULL, &value, /* canModify = */ true,
-                                      &needsBarrier))
+    if (!PropertyWriteNeedsTypeBarrier(cx, current, &object, NULL, &value, /* canModify = */ true,
+                                       &needsBarrier))
     {
         return false;
     }
 
     if (needsBarrier)
         return true;
 
     // Emit SetElementCache.