mozilla-central: changeset 84433:254f355a4a9605a1879326ffdc2ac8e0215c35b8

Bug 712576 - On Android, we place a criteria on the location provider such that it must return a 'fine' grain location. It could be that this prevents some location providers -- ones that have network but not a GPS backed device -- from working. r=jdm

author	Doug Turner <dougt@dougt.org>
	Fri, 13 Jan 2012 16:01:58 -0800
changeset 84433	254f355a4a9605a1879326ffdc2ac8e0215c35b8
parent 84432	9b2f2f9242531212b0071ff3377fb9c989ee51cd
child 84434	b36175bbda47da731573c8031a132a4f2385235d
push id	21848
push user	mak77@bonardo.net
push date	Sat, 14 Jan 2012 09:02:20 +0000
treeherder	mozilla-central@27a7f197c6fc [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	jdm
bugs	712576
milestone	12.0a1
first release with	nightly linux32 21c84409902e / 12.0a1 / 20120115031052 / files nightly linux64 21c84409902e / 12.0a1 / 20120115031052 / files nightly mac 21c84409902e / 12.0a1 / 20120115031052 / files nightly win32 21c84409902e / 12.0a1 / 20120115031052 / files nightly win64 21c84409902e / 12.0a1 / 20120115031052 / files
last release without	nightly linux32 964b118ac852 / 12.0a1 / 20120113031050 / files nightly linux64 964b118ac852 / 12.0a1 / 20120113031050 / files nightly mac 964b118ac852 / 12.0a1 / 20120113031050 / files nightly win32 964b118ac852 / 12.0a1 / 20120113031050 / files nightly win64 8ffdb4c7404a / 12.0a1 / 20120112031044 / files

mobile/android/base/GeckoAppShell.java

file | annotate | diff | comparison | revisions

--- a/mobile/android/base/GeckoAppShell.java
+++ b/mobile/android/base/GeckoAppShell.java
@@ -568,19 +568,18 @@ public class GeckoAppShell
         getMainHandler().post(new Runnable() { 
                 public void run() {
                     LayerView v = GeckoApp.mAppContext.getLayerController().getView();
 
                     LocationManager lm = (LocationManager)
                         GeckoApp.mAppContext.getSystemService(Context.LOCATION_SERVICE);
 
                     if (enable) {
-                        Criteria crit = new Criteria();
-                        crit.setAccuracy(Criteria.ACCURACY_FINE);
-                        String provider = lm.getBestProvider(crit, true);
+                        Criteria criteria = new Criteria();
+                        String provider = lm.getBestProvider(criteria, true);
                         if (provider == null)
                             return;
 
                         Looper l = Looper.getMainLooper();
                         Location loc = lm.getLastKnownLocation(provider);
                         if (loc != null) {
                             GeckoApp.mAppContext.onLocationChanged(loc);
                         }