Bug 1287019 - part2: prevent saving redundant screenshots in mozlog's HTML format result. r=jmaher
authorJeremy Chen <jeremychen@mozilla.com>
Mon, 18 Jul 2016 13:53:58 +0800
changeset 305399 248eb6469a616be3f33df4fc2756d41689cfdf38
parent 305398 124addcb422ff6cf7756fa1b55ca67f98dbb9187
child 305400 78bff0b2ded4a70d0a8ebe88a127f71a9daa861b
push id30463
push usercbook@mozilla.com
push dateTue, 19 Jul 2016 14:02:45 +0000
treeherdermozilla-central@37cc0da01187 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1287019
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1287019 - part2: prevent saving redundant screenshots in mozlog's HTML format result. r=jmaher There are two identical pairs of screenshots (test/reference pair) which are png/base64 raw files generated from mozlog's HTML formatter. One pair is stored in the img element to present the visual result; the other pair is stored as a hyperlink source in the visual result's title. After part1 patch, we may have one more pair. It appears that the hyperlinks of the visual result's titles could be eliminated since they are visually closed to the visual results, and clicking the visual results provides the exact same function. DONTBUILD (NPOTB) MozReview-Commit-ID: 4CLfYXX8g69
testing/mozbase/mozlog/mozlog/formatters/html/html.py
--- a/testing/mozbase/mozlog/mozlog/formatters/html/html.py
+++ b/testing/mozbase/mozlog/mozlog/formatters/html/html.py
@@ -125,20 +125,17 @@ class HTMLFormatter(base.BaseFormatter):
                     ('image1','Image 1 (test)'),
                     ('image2','Image 2 (reference)')
                 ]
                 for title, description in images:
                     screenshot = '%s' % debug[title]
                     additional_html.append(html.div(
                         html.a(html.img(src=screenshot), href="#"),
                         html.br(),
-                        html.a(
-                            description,
-                            href=screenshot,
-                            target='_blank'),
+                        html.a(description),
                         class_='screenshot'))
 
             if debug.get('screenshot'):
                 screenshot = '%s' % debug['screenshot']
                 screenshot = 'data:image/png;base64,' + screenshot
 
                 additional_html.append(html.div(
                     html.a(html.img(src=screenshot), href="#"),