Bug 1396794 - Removed aPacket and aLength change r=kentuckyfriedtakahe
authorBharat Raghunathan <bharatraghunthan9767@gmail.com>
Sat, 16 Sep 2017 07:18:56 +0530
changeset 381402 24833bf7fb61ad0809c5c85b7204ff1a1a5a3768
parent 381401 7df304758224132097e865e6b7c056f1892744e9
child 381403 f59c34720c8037e17f2205f65a2c8cad85455b93
push id32527
push userarchaeopteryx@coole-files.de
push dateMon, 18 Sep 2017 09:31:38 +0000
treeherdermozilla-central@4ef69bbd6816 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskentuckyfriedtakahe
bugs1396794
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1396794 - Removed aPacket and aLength change r=kentuckyfriedtakahe MozReview-Commit-ID: JG9vo3dbMB
dom/media/flac/FlacFrameParser.cpp
--- a/dom/media/flac/FlacFrameParser.cpp
+++ b/dom/media/flac/FlacFrameParser.cpp
@@ -71,18 +71,16 @@ FlacFrameParser::DecodeHeaderBlock(const
 
   mPacketCount++;
 
   if (aPacket[0] == 'f') {
     if (mPacketCount != 1 || memcmp(br.Read(4), "fLaC", 4) ||
         br.Remaining() != FLAC_STREAMINFO_SIZE + 4) {
       return false;
     }
-    aPacket += 4;
-    aLength -= 4;
   }
   uint8_t blockHeader = br.ReadU8();
   // blockType is a misnomer as it could indicate here either a packet type
   // should it points to the start of a Flac in Ogg metadata, or an actual
   // block type as per the flac specification.
   uint32_t blockType = blockHeader & 0x7f;
   bool lastBlock = blockHeader & 0x80;