Bug 618998 - Star UI is checking for about:blank before the real visited page.
authorMarco Bonardo <mbonardo@mozilla.com>
Tue, 14 Dec 2010 09:58:58 -0800
changeset 59387 23c8f19e51f1b92ad7c1ccd0e73ab99d110afa6d
parent 59386 0193e46f04a659f21eef5b20dd491834883baba4
child 59388 ca55136bdf2c3558d4289fbb5028217327d5de0f
push id17602
push usersdwilsh@shawnwilsher.com
push dateThu, 16 Dec 2010 04:39:03 +0000
treeherdermozilla-central@cd62a8afc52e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs618998
milestone2.0b8pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 618998 - Star UI is checking for about:blank before the real visited page. r=sdwilsh a=sdwilsh
browser/base/content/browser-places.js
--- a/browser/base/content/browser-places.js
+++ b/browser/base/content/browser-places.js
@@ -956,16 +956,21 @@ var PlacesStarButton = {
 
     // Reset tracked values.
     this._uri = gBrowser.currentURI;
     this._itemIds = [];
 
     // Hide the star while we update its state.
     this._starIcon.hidden = true;
 
+    // We can load about:blank before the actual page, but there is no point in handling that page.
+    if (this._uri.spec == "about:blank") {
+      return;
+    }
+
     PlacesUtils.asyncGetBookmarkIds(this._uri, function (aItemIds) {
       this._itemIds = aItemIds;
       this._updateStateInternal();
 
       // Start observing bookmarks if needed.
       if (!this._hasBookmarksObserver) {
         try {
           PlacesUtils.bookmarks.addObserver(this, false);