Bug 1419182 - Remove unused required keys feature; r=mshal
authorGregory Szorc <gps@mozilla.com>
Mon, 20 Nov 2017 14:06:35 -0800
changeset 392997 23c4884d53168a8d6f3a8bec350c5f606f63ac41
parent 392996 a75234ffae560e354f2239f6aff0332163ac6281
child 392998 124bb2bb9b39e124249ea5f609d85b76ddad2969
push id32947
push useraciure@mozilla.com
push dateWed, 22 Nov 2017 09:57:59 +0000
treeherdermozilla-central@5378dcb45044 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs1419182
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1419182 - Remove unused required keys feature; r=mshal Nobody passes in the "required" argument. Remove it and functionality related to it. MozReview-Commit-ID: IB8s4CiDy6a
build/compare-mozconfig/compare-mozconfigs.py
--- a/build/compare-mozconfig/compare-mozconfigs.py
+++ b/build/compare-mozconfig/compare-mozconfigs.py
@@ -31,29 +31,21 @@ def make_hg_url(hgHost, repoPath, protoc
             return repo
         else:
             return '/'.join([p.strip('/') for p in [repo, 'rev', revision]])
     else:
         assert revision
         return '/'.join([p.strip('/') for p in [repo, 'raw-file', revision,
                          filename]])
 
-def readConfig(configfile, keys=[], required=[]):
+def readConfig(configfile, keys=[]):
     c = {}
     execfile(configfile, c)
     for k in keys:
         c = c[k]
-    items = c.keys()
-    err = False
-    for key in required:
-        if key not in items:
-            err = True
-            log.error("Required item `%s' missing from %s" % (key, c))
-    if err:
-        raise ConfigError("Missing at least one item in config, see above")
     return c
 
 def verify_mozconfigs(mozconfig_pair, nightly_mozconfig_pair, platform,
                       mozconfigWhitelist={}):
     """Compares mozconfig to nightly_mozconfig and compare to an optional
     whitelist of known differences. mozconfig_pair and nightly_mozconfig_pair
     are pairs containing the mozconfig's identifier and the list of lines in
     the mozconfig."""