Bug 1472373 [wpt PR 11738] - Rewrite BlobBytesConsumer to not rely on blob URLs., a=testonly
authorMarijn Kruisselbrink <mek@chromium.org>
Sat, 07 Jul 2018 00:22:26 +0000
changeset 426147 23a5a863278ccd52e6cb91c412ad475999f662e1
parent 426146 5108caaf4b94ea313d978dfb2ba705878ae06ad1
child 426148 b7c6f80c568da5de83794b5b722bc0eb2ad39935
push id34267
push userrgurzau@mozilla.com
push dateWed, 11 Jul 2018 22:05:21 +0000
treeherdermozilla-central@3aca103e4915 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1472373, 11738, 859109, 1120679, 572363
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472373 [wpt PR 11738] - Rewrite BlobBytesConsumer to not rely on blob URLs., a=testonly Automatic update from web-platform-testsRewrite BlobBytesConsumer to not rely on blob URLs. The existing implementation depended on the non-mojo blob URL code path, and so would break soon after mojo blob URLs ship when the old code gets deleted. So rewrite the implementation to read blobs more directly rather than going through a blob URL. Bug: 859109 Change-Id: Ia6f2432e48ac5304ea8f5598d293e31c2c1e1905 Reviewed-on: https://chromium-review.googlesource.com/1120679 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572363} -- wpt-commits: 8f6ed28158100d414ddac343e6a6f44a74a37e3a wpt-pr: 11738
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/fetch/api/response/response-cancel-stream.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -571837,17 +571837,17 @@
    "38946a76b98b46be5edf2031a16c3c4cfb4caab1",
    "support"
   ],
   "fetch/api/response/multi-globals/url-parsing.html": [
    "14ab44d0a8627682afc024856c08a931c58db3d6",
    "testharness"
   ],
   "fetch/api/response/response-cancel-stream.html": [
-   "453323c2a0f9a908966df3cb53211c0b0a1fa19d",
+   "ad839d3e6234d16aa61338b732f765572cf8291f",
    "testharness"
   ],
   "fetch/api/response/response-clone.html": [
    "4fde2d5591959ef413f5f5695a8eebd6cb193fff",
    "testharness"
   ],
   "fetch/api/response/response-consume-empty.html": [
    "a9606b70a21e24dde0da19656773fc0c60fa255f",
--- a/testing/web-platform/tests/fetch/api/response/response-cancel-stream.html
+++ b/testing/web-platform/tests/fetch/api/response/response-cancel-stream.html
@@ -25,17 +25,19 @@ promise_test(function(test) {
 
 promise_test(function(test) {
     var response = new Response(new Blob(["T"], { "type" : "text/plain" }));
     var reader = response.body.getReader();
 
     var closedPromise = reader.closed.then(function() {
         return reader.cancel();
     });
-    reader.read();
+    reader.read().then(function readMore({done, value}) {
+      if (!done) return reader.read().then(readMore);
+    });
     return closedPromise;
 }, "Cancelling a closed blob Response stream");
 
 promise_test(function(test) {
     return fetch(RESOURCES_DIR + "trickle.py?ms=30&count=100").then(function(response) {
         return response.body.cancel();
     });
 }, "Cancelling a starting Response stream");