Bug 1756162 - Make the visibility of the "Top Pick" checkbox depend entirely on whether the best match feature is enabled. r=preferences-reviewers,Gijs
☠☠ backed out by a1ee11df1dc9 ☠ ☠
authorDrew Willcoxon <adw@mozilla.com>
Wed, 23 Feb 2022 03:43:14 +0000
changeset 608452 2316e8b1ed0edc22e2aa86acf539a527e0d670d9
parent 608451 b557ab9ead864b08ec185a2e0e6a82be8fc5afb8
child 608453 0eeb3355fab579b1f4c4392f75f292c23be53749
push id39327
push userccozmuta@mozilla.com
push dateWed, 23 Feb 2022 09:38:00 +0000
treeherdermozilla-central@52454ded3095 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspreferences-reviewers, Gijs
bugs1756162
milestone99.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1756162 - Make the visibility of the "Top Pick" checkbox depend entirely on whether the best match feature is enabled. r=preferences-reviewers,Gijs We've made a few changes to this "Top pick" checkbox recently based on shifting Product requirements, and the problem here is that the checkbox used to be inside the Firefox Suggest container, but we recently moved it outside the container. The Firefox Suggest container is properly hidden or shown depending on whether the Suggest feature is enabled, so when the checkbox was inside the container and Suggest was disabled, the checkbox properly got hidden too. Now that the checkbox is outside that container, its visibility needs to entirely depend on whether the best match feature is enabled. So all this revision does is move the checkbox's `hidden` assignment from inside the "is Suggest enabled" if-block to outside the if-block. It also sets `hidden=true` on the checkbox in the markup for good measure. I also improved the test so it checks every combination of enabled statuses between the Suggest and best match features. Depends on D138987 Differential Revision: https://phabricator.services.mozilla.com/D139161
browser/components/preferences/tests/browser_privacy_firefoxSuggest.js
--- a/browser/components/preferences/tests/browser_privacy_firefoxSuggest.js
+++ b/browser/components/preferences/tests/browser_privacy_firefoxSuggest.js
@@ -38,20 +38,19 @@ const EXPECTED_L10N_IDS = {
     disabled: "addressbar-header",
   },
   locationBarSuggestionLabel: {
     enabled: "addressbar-suggest-firefox-suggest",
     disabled: "addressbar-suggest",
   },
 };
 
-// Allow more time for Mac machines so they don't time out in verify mode.
-if (AppConstants.platform == "macosx") {
-  requestLongerTimeout(3);
-}
+// This test can take a while due to the many permutations some of these tasks
+// run through, so request a longer timeout.
+requestLongerTimeout(10);
 
 // The following tasks check the visibility of the Firefox Suggest UI based on
 // the value of the feature pref. See doVisibilityTest().
 
 add_task(async function historyToOffline() {
   await doVisibilityTest({
     initialScenario: "history",
     initialExpectedVisibility: false,