Bug 1517196 - [geckodriver] Fix unit test for invalid frame id. r=ato
authorHenrik Skupin <mail@hskupin.info>
Wed, 09 Jan 2019 16:22:00 +0000
changeset 453064 227e15964de828de138b0b01b28e07f384b2f247
parent 453063 68dbd12b85475b9bb6dc19cc2c45a3158f140b97
child 453065 c429964db93ce00306562cc471453ce9adfcf0fb
push id35344
push usershindli@mozilla.com
push dateWed, 09 Jan 2019 21:41:24 +0000
treeherdermozilla-central@47ced8013922 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1517196
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1517196 - [geckodriver] Fix unit test for invalid frame id. r=ato Depends on D16049 Differential Revision: https://phabricator.services.mozilla.com/D15953
testing/webdriver/src/command.rs
--- a/testing/webdriver/src/command.rs
+++ b/testing/webdriver/src/command.rs
@@ -984,17 +984,17 @@ mod tests {
         let json = r#"{}"#;
         let data = SwitchToFrameParameters { id: None };
 
         check_deserialize(&json, &data);
     }
 
     #[test]
     fn test_json_switch_to_frame_parameters_with_invalid_id_field() {
-        let json = r#"{"id":"3""#;
+        let json = r#"{"id":"3"}"#;
 
         assert!(serde_json::from_str::<SwitchToFrameParameters>(&json).is_err());
     }
 
     #[test]
     fn test_json_switch_to_window_parameters_with_value() {
         let json = r#"{"handle":"foo"}"#;
         let data = SwitchToWindowParameters {