Bug 1330147 - fix by hand the issues raised by the new no-useless-parameters eslint rule, r=jaws.
authorFlorian Quèze <florian@queze.net>
Wed, 11 Jan 2017 22:27:43 +0100
changeset 329039 224c1524464dd3d5311fce2c403b36f902ea9a6e
parent 329038 8e0b7bc5fd7164d083261a709bdf3dc0266365ca
child 329040 ccf9b5082e8b6d8f0c833b70c841325ecfbc7296
push id31194
push usercbook@mozilla.com
push dateThu, 12 Jan 2017 09:14:59 +0000
treeherdermozilla-central@97d6f7364394 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1330147
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1330147 - fix by hand the issues raised by the new no-useless-parameters eslint rule, r=jaws.
browser/base/content/tabbrowser.xml
browser/base/content/test/general/test_offlineNotification.html
devtools/client/inspector/rules/test/doc_author-sheet.html
devtools/client/inspector/shared/test/doc_author-sheet.html
toolkit/components/remotebrowserutils/tests/browser/browser_RemoteWebNavigation.js
toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -5020,19 +5020,19 @@
           // window ID. We switched to a monotonic counter as Date.now() lead
           // to random failures because of colliding IDs.
           return "panel-" + outerID + "-" + (++this._uniquePanelIDCounter);
         ]]></body>
       </method>
 
       <destructor>
         <![CDATA[
-          Services.obs.removeObserver(this, "live-resize-start", false);
-          Services.obs.removeObserver(this, "live-resize-end", false);
-          Services.obs.removeObserver(this, "contextual-identity-updated", false);
+          Services.obs.removeObserver(this, "live-resize-start");
+          Services.obs.removeObserver(this, "live-resize-end");
+          Services.obs.removeObserver(this, "contextual-identity-updated");
 
           for (let tab of this.tabs) {
             let browser = tab.linkedBrowser;
             if (browser.registeredOpenURI) {
               this._unifiedComplete.unregisterOpenPage(browser.registeredOpenURI,
                                                        browser.getAttribute("usercontextid") || 0);
               delete browser.registeredOpenURI;
             }
--- a/browser/base/content/test/general/test_offlineNotification.html
+++ b/browser/base/content/test/general/test_offlineNotification.html
@@ -35,18 +35,18 @@ window.addEventListener("message", funct
     is(event.data, "success", "Child was successfully cached.");
 
     if (++numFinished == 3) {
       // Clean up after ourself
       var pm = Cc["@mozilla.org/permissionmanager;1"].
                getService(SpecialPowers.Ci.nsIPermissionManager);
       var ioService = Cc["@mozilla.org/network/io-service;1"]
                         .getService(SpecialPowers.Ci.nsIIOService);
-      var uri1 = ioService.newURI(frames.testFrame.location, null, null);
-      var uri2 = ioService.newURI(frames.testFrame3.location, null, null);
+      var uri1 = ioService.newURI(frames.testFrame.location);
+      var uri2 = ioService.newURI(frames.testFrame3.location);
 
       var ssm = Cc["@mozilla.org/scriptsecuritymanager;1"]
                   .getService(SpecialPowers.Ci.nsIScriptSecurityManager);
       var principal1 = ssm.createCodebasePrincipal(uri1, {});
       var principal2 = ssm.createCodebasePrincipal(uri2, {});
 
       pm.removeFromPrincipal(principal1, "offline-app");
       pm.removeFromPrincipal(principal2, "offline-app");
--- a/devtools/client/inspector/rules/test/doc_author-sheet.html
+++ b/devtools/client/inspector/rules/test/doc_author-sheet.html
@@ -11,17 +11,17 @@
   </style>
 
   <script>
     "use strict";
     var gIOService = SpecialPowers.Cc["@mozilla.org/network/io-service;1"]
                                   .getService(SpecialPowers.Ci.nsIIOService);
 
     var style = "data:text/css,a { background-color: seagreen; }";
-    var uri = gIOService.newURI(style, null, null);
+    var uri = gIOService.newURI(style);
     var windowUtils = SpecialPowers.wrap(window)
         .QueryInterface(SpecialPowers.Ci.nsIInterfaceRequestor)
         .getInterface(SpecialPowers.Ci.nsIDOMWindowUtils);
     windowUtils.loadSheet(uri, windowUtils.AUTHOR_SHEET);
   </script>
 
 </head>
 <body>
--- a/devtools/client/inspector/shared/test/doc_author-sheet.html
+++ b/devtools/client/inspector/shared/test/doc_author-sheet.html
@@ -9,17 +9,17 @@
     }
   </style>
   <script>
     "use strict";
     var gIOService = SpecialPowers.Cc["@mozilla.org/network/io-service;1"]
                                   .getService(SpecialPowers.Ci.nsIIOService);
 
     var style = "data:text/css,div { background-color: seagreen; }";
-    var uri = gIOService.newURI(style, null, null);
+    var uri = gIOService.newURI(style);
     var windowUtils = SpecialPowers.wrap(window)
                       .QueryInterface(SpecialPowers.Ci.nsIInterfaceRequestor)
                       .getInterface(SpecialPowers.Ci.nsIDOMWindowUtils);
     windowUtils.loadSheet(uri, windowUtils.AUTHOR_SHEET);
   </script>
 </head>
 <body>
   <div id="target"> the ocean </div>
--- a/toolkit/components/remotebrowserutils/tests/browser/browser_RemoteWebNavigation.js
+++ b/toolkit/components/remotebrowserutils/tests/browser/browser_RemoteWebNavigation.js
@@ -19,17 +19,17 @@ function waitForPageShow(browser = gBrow
       resolve();
     }, true);
   });
 }
 
 function makeURI(url) {
   return Cc["@mozilla.org/network/io-service;1"].
          getService(Ci.nsIIOService).
-         newURI(url, null, null);
+         newURI(url);
 }
 
 // Tests that loadURI accepts a referrer and it is included in the load.
 add_task(function* test_referrer() {
   gBrowser.selectedTab = gBrowser.addTab();
   let browser = gBrowser.selectedBrowser;
 
   browser.webNavigation.loadURI(DUMMY1,
--- a/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
+++ b/toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
@@ -42,17 +42,17 @@ const PREFERENCE_NAME = "test-pref";
  *
  * @param aURIString
  *        The spec of the URI to create.
  * @returns an nsIURI representing aURIString.
  */
 function uri(aURIString) {
   return Cc["@mozilla.org/network/io-service;1"].
          getService(Ci.nsIIOService).
-         newURI(aURIString, null, null);
+         newURI(aURIString);
 }
 
 /**
  * Asynchronously check a url is visited.
  *
  * @param aURI
  *        The URI.
  *