Bug 1632988 [wpt PR 23240] - Update two SVG tests to be consistent between browsers, a=testonly
authorMyles C. Maxfield <litherum@icloud.com>
Tue, 28 Apr 2020 11:44:27 +0000
changeset 527655 21f3e5c1d6d202723332cdf0d872238d275bbb1b
parent 527654 d700bf57b90b613f5dee497a4a7f6a3c2d665476
child 527656 b385b9e049d31a78e7016c0f2e4fbe1048ffa832
push id37368
push userbtara@mozilla.com
push dateFri, 01 May 2020 21:45:51 +0000
treeherdermozilla-central@0f9c5a59e45d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1632988, 23240
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1632988 [wpt PR 23240] - Update two SVG tests to be consistent between browsers, a=testonly Automatic update from web-platform-tests Update two SVG tests to be consistent between browsers (#23240) svg/import/pservers-grad-08-b-manual.svg: This test renders some text using a font that doesn't contain the space glyph. However, the content contains the space character, and doesn't specify a fallback font. This means that different browsers on the same OS will pick different fallback fonts, causing different renderings. Instead, the test should be updated to specify a fallback font, which makes browsers render it consistently. imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual.svg: Similarly, this test renders text with a font that doesn't support those characters. (It does it using <altGlyph>, but support for <altGlyph> has been removed in SVG 2.0 and neither Safari nor Firefox support it.) A fallback font should be supplied to the test to get consistent renderings across browsers. Co-authored-by: Myles C. Maxfield <mmaxfield@apple.com> -- wpt-commits: 51151cf5bfc32adb8d96fca51a30c126d1e0200d wpt-pr: 23240
testing/web-platform/tests/svg/import/pservers-grad-08-b-manual.svg
testing/web-platform/tests/svg/import/text-altglyph-01-b-manual.svg
--- a/testing/web-platform/tests/svg/import/pservers-grad-08-b-manual.svg
+++ b/testing/web-platform/tests/svg/import/pservers-grad-08-b-manual.svg
@@ -70,21 +70,21 @@
       <!-- ====================================================================== -->
       <linearGradient id="Gradient" gradientUnits="userSpaceOnUse" x1="10" y1="10" x2="440" y2="10">
         <stop stop-color="blue" offset="0"/>
         <stop stop-color="lime" offset="1"/>
       </linearGradient>
       <!-- ====================================================================== -->
       <!-- Gradient on fill of text                                      ======== -->
       <!-- ====================================================================== -->
-      <text font-family="Blocky" font-size="68" fill="url(#Gradient)" x="20" y="70">Gradient on fill</text>
+      <text font-family="Blocky, sans-serif" font-size="68" fill="url(#Gradient)" x="20" y="70">Gradient on fill</text>
       <!-- ====================================================================== -->
       <!-- Gradient on stroke of text                                    ======== -->
       <!-- ====================================================================== -->
-      <text font-family="Blocky" x="20" y="160" font-size="55" fill="none" stroke="url(#Gradient)" stroke-width="3">Gradient on stroke</text>
+      <text font-family="Blocky, sans-serif" x="20" y="160" font-size="55" fill="none" stroke="url(#Gradient)" stroke-width="3">Gradient on stroke</text>
 
     </g>
       <g font-family="SVGFreeSansASCII,sans-serif" font-size="28">
         <text  x="40" y="145">Linear gradient on filled text</text>
         <text  x="30" y="280">Linear gradient on stroke of text</text>
       </g>
   </g>
   <g font-family="SVGFreeSansASCII,sans-serif" font-size="32">
--- a/testing/web-platform/tests/svg/import/text-altglyph-01-b-manual.svg
+++ b/testing/web-platform/tests/svg/import/text-altglyph-01-b-manual.svg
@@ -95,17 +95,17 @@
         </altGlyphDef>
         <altGlyphDef id="Sfrown">
           <glyphRef xlink:href="#S2"/>
         </altGlyphDef>
         <altGlyphDef id="Ysmile">
           <glyphRef xlink:href="#Y1"/>
         </altGlyphDef>
       </defs>
-      <g font-family="HappySad" font-size="60" fill="none" stroke-width="5">
+      <g font-family="HappySad, sans-serif" font-size="60" fill="none" stroke-width="5">
         <text x="140" y="190" stroke="fuchsia">
 <altGlyph xlink:href="#Hsmile">H</altGlyph>
 <altGlyph xlink:href="#Asmile">A</altGlyph>
 <altGlyph xlink:href="#Psmile">P</altGlyph>
 <altGlyph xlink:href="#Psmile">P</altGlyph>
 <altGlyph xlink:href="#Ysmile">Y</altGlyph>
         </text>
         <text x="50" y="270" stroke="green">