Bug 1526570 [wpt PR 15030] - implemented 3 corrections detailed in issue 14160, a=testonly
authorGérard Talbot <github@gtalbot.org>
Tue, 12 Feb 2019 14:40:52 +0000
changeset 459300 21890326fccb73b431081234a195c11b22fdf1d2
parent 459299 2f92effe196e0f5cda6f6216dc51a36d24083eba
child 459301 b0e1a0389ad08fecc8defae1c0966677cbf0c643
push id35557
push userdvarga@mozilla.com
push dateFri, 15 Feb 2019 01:42:08 +0000
treeherdermozilla-central@426ca85d2303 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1526570, 15030, 14160
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1526570 [wpt PR 15030] - implemented 3 corrections detailed in issue 14160, a=testonly Automatic update from web-platform-tests implemented 3 corrections detailed in issue 14160 -- wpt-commits: 1b287f0aacb42858364d26aeaa2b72e336e81fba wpt-pr: 15030
testing/web-platform/tests/css/css-values/lh-rlh-on-root-001.html
--- a/testing/web-platform/tests/css/css-values/lh-rlh-on-root-001.html
+++ b/testing/web-platform/tests/css/css-values/lh-rlh-on-root-001.html
@@ -40,23 +40,23 @@
     window.document.documentElement.style="font-size: 142px; line-height: 1rlh;";
     l_h = get_root_line_height();
     assert_approx_equals( l_h, initial_l_h, 1, "the rlh unit on the root element's line-height property uses font metrics corresponding to the initial values of the font or line-height properties");
   }, "rlh in line-height on root");
 
   test(function() {
     window.document.documentElement.style="font-size: 1lh; line-height: 142px;";
     f_s = get_root_font_size();
-    assert_approx_equals( f_s, initial_f_s, 1, "the lh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");
+    assert_approx_equals( f_s, initial_l_h, 1, "the lh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");
   }, "lh in font-size on root");
 
   test(function() {
     window.document.documentElement.style="font-size: 1rlh; line-height: 142px;";
     f_s = get_root_font_size();
-    assert_approx_equals( f_s, initial_f_s, 1, "the rlh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");
+    assert_approx_equals( f_s, initial_l_h, 1, "the rlh unit on the root element's font-size property uses font metrics corresponding to the initial values of the font or line-height properties");
 
   }, "rlh in font-size on root");
 
 
   test(function() {
     window.document.documentElement.style="font-size: 142px; line-height: 2lh;";
     l_h = get_root_line_height();
     assert_approx_equals( l_h, initial_l_h * 2, 1, "the lh unit on the root element's line-height property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");
@@ -66,17 +66,17 @@
     window.document.documentElement.style="font-size: 142px; line-height: 2rlh;";
     l_h = get_root_line_height();
     assert_approx_equals( l_h, initial_l_h * 2, 1, "the rlh unit on the root element's line-height property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");
   }, "2rlh in line-height on root");
 
   test(function() {
     window.document.documentElement.style="font-size: 2lh; line-height: 142px;";
     f_s = get_root_font_size();
-    assert_approx_equals( f_s, initial_f_s * 2, 1, "the lh unit on the root element's font-size property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");
+    assert_approx_equals( f_s, initial_l_h * 2, 1, "the lh unit on the root element's font-size property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");
   }, "2lh in font-size on root");
 
   test(function() {
     window.document.documentElement.style="font-size: 2rlh; line-height: 142px;";
     f_s = get_root_font_size();
     assert_approx_equals( f_s, initial_f_s * 2, 1, "the rlh unit on the root element's font-size property actually works as a unit and doesn't merely cause a fallback that doesn't take the number of units into account");
 
   }, "2rlh in font-size on root");