Bug 1604335 - Enable PHC on early beta. r=erahm
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 27 Dec 2019 04:34:33 +0000
changeset 508428 216df035bdf57aaea5c609bafc71c042b897ef99
parent 508427 44aea81297a2020f5e72d83dbdbba80a07d0ef19
child 508429 0da35540b330b7bb2d840c1fe0ceeb151cf0e681
push id36959
push usernerli@mozilla.com
push dateSat, 28 Dec 2019 04:06:02 +0000
treeherdermozilla-central@20b3a68275d5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1604335
milestone73.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1604335 - Enable PHC on early beta. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D58285
build/moz.configure/memory.configure
--- a/build/moz.configure/memory.configure
+++ b/build/moz.configure/memory.configure
@@ -18,17 +18,17 @@ set_config('MOZ_MEMORY', True, when='--e
 set_define('MOZ_MEMORY', True, when='--enable-jemalloc')
 add_old_configure_assignment('MOZ_MEMORY', True, when='--enable-jemalloc')
 
 
 @depends(milestone, build_project)
 def replace_malloc_default(milestone, build_project):
     if build_project == 'memory':
         return True
-    if milestone.is_nightly and build_project != 'js':
+    if milestone.is_early_beta_or_earlier and build_project != 'js':
         return True
 
 
 js_option('--enable-replace-malloc', default=replace_malloc_default,
           when='--enable-jemalloc',
           help='{Enable|Disable} ability to dynamically replace the malloc implementation')
 
 
@@ -52,18 +52,18 @@ set_config('MOZ_REPLACE_MALLOC_STATIC', 
 # In general, it only makes sense for PHC to run on the platforms that have a
 # crash reporter.
 @depends(milestone, target, replace_malloc_default, '--enable-replace-malloc',
          when='--enable-jemalloc')
 def phc_default(milestone, target, replace_malloc_default, replace_malloc):
     if not replace_malloc_default or \
        (replace_malloc.origin != 'default' and not replace_malloc):
         return False
-    # Nightly only because PHC has a non-negligible performance cost.
-    if not milestone.is_nightly:
+    # Nightly or early beta only because PHC has a non-negligible performance cost.
+    if not milestone.is_early_beta_or_earlier:
         return False
     # Both Linux32 and Win32 have frequent crashes when stack tracing (for
     # unclear reasons), so PHC is enabled only on 64-bit only in both cases.
     #
     # XXX: PHC is implemented but not yet enabled on Mac. Bug 1576515 is about
     #      enabling it on Mac, but it is blocked by bug 1035892.
     return (target.os == 'GNU' and target.kernel == 'Linux' and
             target.bitness == 64) or \