Bug 1380255 P3 Disable channel thread retargeting when webrequest is tracing the channel. r=kmag
authorBen Kelly <ben@wanderview.com>
Thu, 12 Oct 2017 19:23:16 -0700
changeset 386045 213cba8335fda4ecf60316a860fe4dd4cff25ebc
parent 386044 839e4b1245ca8a6eb64b52188e56bfd1e4895584
child 386046 e2eb7a581bde8b06b95f64b3dda74a3892cd41bf
push id32673
push userarchaeopteryx@coole-files.de
push dateFri, 13 Oct 2017 09:13:17 +0000
treeherdermozilla-central@196dadb2fe50 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1380255
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1380255 P3 Disable channel thread retargeting when webrequest is tracing the channel. r=kmag
toolkit/components/extensions/webrequest/StreamFilterParent.cpp
--- a/toolkit/components/extensions/webrequest/StreamFilterParent.cpp
+++ b/toolkit/components/extensions/webrequest/StreamFilterParent.cpp
@@ -116,21 +116,18 @@ StreamFilterParent::Init(nsIChannel* aCh
  * nsIThreadRetargetableStreamListener
  *****************************************************************************/
 
 NS_IMETHODIMP
 StreamFilterParent::CheckListenerChain()
 {
   AssertIsMainThread();
 
-  nsCOMPtr<nsIThreadRetargetableStreamListener> trsl =
-    do_QueryInterface(mOrigListener);
-  if (trsl) {
-    return trsl->CheckListenerChain();
-  }
+  // Disable thread retargeting due to segments being delivbered out-of-order.
+  // See bug 1405286.
   return NS_ERROR_FAILURE;
 }
 
 /*****************************************************************************
  * Error handling
  *****************************************************************************/
 
 void