Bug 1330240 - Limit -Wthread-safety to WebRTC due to lack of annotations. r=cpeterson,froydnj,jesup
☠☠ backed out by 7d50c8e3086d ☠ ☠
authorJan Beich <jbeich@FreeBSD.org>
Wed, 11 Jan 2017 16:50:18 +0000
changeset 344392 20a81b2adf80e957b66aa861ff8159198c7d3684
parent 344391 27b94a28f81502a7c0ae13e4f4979019659c47b6
child 344393 27dade5e0c8350189eeb6495d70a9fb25ce137a9
push id31407
push usercbook@mozilla.com
push dateThu, 23 Feb 2017 13:58:01 +0000
treeherdermozilla-central@27dade5e0c83 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpeterson, froydnj, jesup
bugs1330240
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1330240 - Limit -Wthread-safety to WebRTC due to lack of annotations. r=cpeterson,froydnj,jesup MozReview-Commit-ID: HuoXFwZkdYo
build/moz.configure/warnings.configure
media/webrtc/trunk/webrtc/build/common.gypi
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -73,19 +73,16 @@ check_and_add_gcc_warning('-Wimplicit-fa
 # --enable-warnings-as-errors is specified so that no unexpected fatal
 # warnings are produced.
 check_and_add_gcc_warning('-Werror=non-literal-null-conversion',
                           when='--enable-warnings-as-errors')
 
 # catches string literals used in boolean expressions
 check_and_add_gcc_warning('-Wstring-conversion')
 
-# catches inconsistent use of mutexes
-check_and_add_gcc_warning('-Wthread-safety')
-
 # we inline 'new' and 'delete' in mozalloc
 check_and_add_gcc_warning('-Wno-inline-new-delete', cxx_compiler)
 
 # Prevent the following GCC warnings from being treated as errors:
 # too many false positives
 check_and_add_gcc_warning('-Wno-error=maybe-uninitialized')
 
 # we don't want our builds held hostage when a platform-specific API
--- a/media/webrtc/trunk/webrtc/build/common.gypi
+++ b/media/webrtc/trunk/webrtc/build/common.gypi
@@ -321,16 +321,19 @@
               '-Woverloaded-virtual',
             ],
           }],
           ['clang==1', {
             'cflags': [
               '-Wimplicit-fallthrough',
               '-Wthread-safety',
             ],
+            'cflags_mozilla': [
+              '-Wthread-safety',
+            ],
           }],
         ],
       }],
       ['target_arch=="arm64"', {
         'defines': [
           'WEBRTC_ARCH_ARM64',
           'WEBRTC_HAS_NEON',
         ],