Bug 1510367 - More precisely specify the |breakpoint| function that ought be broken on in js/src/gdb/tests tests so that we don't mis-specify it on js::jit::AssemblerX86Shared::breakpoint. :-\ r=jimb
authorJeff Walden <jwalden@mit.edu>
Tue, 20 Nov 2018 09:45:21 -0800
changeset 448937 203424f500da8a1f759ee8be89d3274567926a3f
parent 448847 9268bf6329ffd7c0fbbb3712cba7b91bbea1f2c0
child 448938 b26e28ce8cfebb91f1c5764606585b8b670938ff
push id35130
push usernerli@mozilla.com
push dateFri, 30 Nov 2018 09:35:34 +0000
treeherdermozilla-central@58a0412e1557 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimb
bugs1510367
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510367 - More precisely specify the |breakpoint| function that ought be broken on in js/src/gdb/tests tests so that we don't mis-specify it on js::jit::AssemblerX86Shared::breakpoint. :-\ r=jimb
js/src/gdb/lib-for-tests/prologue.py
--- a/js/src/gdb/lib-for-tests/prologue.py
+++ b/js/src/gdb/lib-for-tests/prologue.py
@@ -9,17 +9,17 @@ import traceback
 sys.path[0:0] = [testlibdir]
 
 active_fragment = None
 
 # Run the C++ fragment named |fragment|, stopping on entry to |function|
 # ('breakpoint', by default) and then select the calling frame.
 
 
-def run_fragment(fragment, function='breakpoint'):
+def run_fragment(fragment, function='gdb-tests.cpp:breakpoint'):
     # Arrange to stop at a reasonable place in the test program.
     bp = gdb.Breakpoint(function)
     try:
         gdb.execute("run %s" % (fragment,))
         # Check that we did indeed stop by hitting the breakpoint we set.
         assert bp.hit_count == 1
     finally:
         bp.delete()