Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance() r=mattwoodrow
authorsotaro <sotaro.ikeda.g@gmail.com>
Thu, 07 Feb 2019 20:28:30 +0000
changeset 457654 1fb53779a65c7b12f10b61c288e0bd20776443b8
parent 457653 04b57ffa53ce4c248bc3869247fed266b37eab2f
child 457655 55f7952d947c940951cb04bc2da69b9a3779f5da
push id35516
push userrmaries@mozilla.com
push dateFri, 08 Feb 2019 04:23:26 +0000
treeherdermozilla-central@d599d1a73a3a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1525818
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance() r=mattwoodrow Sometimes NS_ASSERTION was hit during window closing. It happens because of aync architecture. It is better to change the NS_ASSERTION to NS_WARNING. Differential Revision: https://phabricator.services.mozilla.com/D18920
gfx/layers/ipc/ImageBridgeParent.cpp
--- a/gfx/layers/ipc/ImageBridgeParent.cpp
+++ b/gfx/layers/ipc/ImageBridgeParent.cpp
@@ -355,17 +355,17 @@ void ImageBridgeParent::DeferredDestroy(
 }
 
 already_AddRefed<ImageBridgeParent> ImageBridgeParent::GetInstance(
     ProcessId aId) {
   MOZ_ASSERT(CompositorThreadHolder::IsInCompositorThread());
   MonitorAutoLock lock(*sImageBridgesLock);
   ImageBridgeMap::const_iterator i = sImageBridges.find(aId);
   if (i == sImageBridges.end()) {
-    NS_ASSERTION(false, "Cannot find image bridge for process!");
+    NS_WARNING("Cannot find image bridge for process!");
     return nullptr;
   }
   RefPtr<ImageBridgeParent> bridge = i->second;
   return bridge.forget();
 }
 
 bool ImageBridgeParent::AllocShmem(size_t aSize,
                                    ipc::SharedMemory::SharedMemoryType aType,