Bug 1599416 - Part 1: Remove unused OutlineTypedObject::notifyBufferDetached method. r=mgaudet
authorAndré Bargull <andre.bargull@gmail.com>
Wed, 27 Nov 2019 13:53:12 +0000
changeset 504037 1f76130b2caecc112b703b369b4d0f55a115e2f6
parent 504036 432a6d44236d2f6f5efd083fd14e0a1a0a34aa9e
child 504038 ade7361b947cc69d2b4f530082b851aa8fbb99f3
push id36855
push useraiakab@mozilla.com
push dateWed, 27 Nov 2019 21:56:55 +0000
treeherdermozilla-central@62ae0fda7cb6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmgaudet
bugs1599416
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1599416 - Part 1: Remove unused OutlineTypedObject::notifyBufferDetached method. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54705
js/src/builtin/TypedObject.cpp
js/src/builtin/TypedObject.h
--- a/js/src/builtin/TypedObject.cpp
+++ b/js/src/builtin/TypedObject.cpp
@@ -2165,20 +2165,16 @@ bool TypedObject::obj_newEnumerate(JSCon
       }
       break;
     }
   }
 
   return true;
 }
 
-void OutlineTypedObject::notifyBufferDetached(void* newData) {
-  setData(reinterpret_cast<uint8_t*>(newData));
-}
-
 /******************************************************************************
  * Inline typed objects
  */
 
 /* static */
 InlineTypedObject* InlineTypedObject::create(JSContext* cx,
                                              HandleTypeDescr descr,
                                              gc::InitialHeap heap) {
--- a/js/src/builtin/TypedObject.h
+++ b/js/src/builtin/TypedObject.h
@@ -701,19 +701,16 @@ class OutlineTypedObject : public TypedO
                                            uint32_t offset);
 
   // Use this method when `buffer` is the owner of the memory.
   void attach(JSContext* cx, ArrayBufferObject& buffer, uint32_t offset);
 
   // Otherwise, use this to attach to memory referenced by another typedObj.
   void attach(JSContext* cx, TypedObject& typedObj, uint32_t offset);
 
-  // Invoked when array buffer is transferred elsewhere
-  void notifyBufferDetached(void* newData);
-
   static void obj_trace(JSTracer* trace, JSObject* object);
 };
 
 // Class for a transparent typed object whose owner is an array buffer.
 class OutlineTransparentTypedObject : public OutlineTypedObject {
  public:
   static const JSClass class_;
 };