Bug 1507334 - Remove '10' argument to profileserver.py; r=firefox-build-system-reviewers,chmanchester#firefox-build-system-reviewers
authorMike Shal <mshal@mozilla.com>
Thu, 10 Jan 2019 01:34:39 +0000
changeset 453189 1f487879b4d7fd68d64edc3fb211d0fbfdb97987
parent 453188 2f2b4d6aabeb00640e80a22309387c8390988b47
child 453190 6f12b99d521ca62132a90805029724defe4f062b
push id35348
push useropoprus@mozilla.com
push dateThu, 10 Jan 2019 09:38:54 +0000
treeherdermozilla-central@74bb778f7879 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfirefox-build-system-reviewers, chmanchester
bugs1507334, 663251, 672563
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507334 - Remove '10' argument to profileserver.py; r=firefox-build-system-reviewers,chmanchester#firefox-build-system-reviewers Support for running profileserver.py multiple times was originally added in bug 663251 and subsequently removed in bug 672563. Since then we've been copying around the argument to profileserver.py from mozconfigs in buildbot-configs, to mozconfigs in mozilla-central, to client.mk, and ultimately to Makefile.in. It no longer does anything and can be removed. Differential Revision: https://phabricator.services.mozilla.com/D15748
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -182,17 +182,17 @@ profiledbuild::
 	$(call BUILDSTATUS,TIER_START pgo_profile_generate)
 	$(MAKE) default MOZ_PROFILE_GENERATE=1
 	$(call BUILDSTATUS,TIER_FINISH pgo_profile_generate)
 	$(call BUILDSTATUS,TIER_START pgo_package)
 	$(MAKE) package MOZ_INTERNAL_SIGNING_FORMAT= MOZ_EXTERNAL_SIGNING_FORMAT=
 	rm -f jarlog/en-US.log
 	$(call BUILDSTATUS,TIER_FINISH pgo_package)
 	$(call BUILDSTATUS,TIER_START pgo_profile)
-	JARLOG_FILE=jarlog/en-US.log $(PYTHON) $(topsrcdir)/build/pgo/profileserver.py 10
+	JARLOG_FILE=jarlog/en-US.log $(PYTHON) $(topsrcdir)/build/pgo/profileserver.py
 	$(call BUILDSTATUS,TIER_FINISH pgo_profile)
 	$(call BUILDSTATUS,TIER_START pgo_clobber)
 	$(MAKE) maybe_clobber_profiledbuild
 	$(call BUILDSTATUS,TIER_FINISH pgo_clobber)
 	$(call BUILDSTATUS,TIER_START pgo_profile_use)
 	$(MAKE) default MOZ_PROFILE_USE=1 $(if $(CLANG_CL),MOZ_PROFILE_ORDER_FILE=$(topobjdir)/cygprofile.txt)
 	$(call BUILDSTATUS,TIER_FINISH pgo_profile_use)