Bug 582521 - Fix xpconnect 'char' conversions in DEBUG builds. r=bz, a=sayrer
authorDan Witte <dwitte@mozilla.com>
Wed, 28 Jul 2010 12:10:27 -0700
changeset 48620 1f3358bd4ef451e2033383b063ee02e76c0cbe90
parent 48619 babf32a4534986122a04b521cd04483cd54da7f6
child 48621 c987f1940582bd70027541f01ef44431f0242510
push id14748
push userrsayre@mozilla.com
push dateSun, 01 Aug 2010 00:33:23 +0000
treeherdermozilla-central@f0df797bb2a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz, sayrer
bugs582521
milestone2.0b3pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 582521 - Fix xpconnect 'char' conversions in DEBUG builds. r=bz, a=sayrer
js/src/xpconnect/src/xpcconvert.cpp
--- a/js/src/xpconnect/src/xpcconvert.cpp
+++ b/js/src/xpconnect/src/xpcconvert.cpp
@@ -596,17 +596,16 @@ XPCConvert::JSData2Native(XPCCallContext
             {
                 return JS_FALSE;
             }
 #ifdef DEBUG
             const jschar* chars=nsnull;
             if(nsnull!=(chars = JS_GetStringCharsZ(cx, str)))
             {
                 NS_ASSERTION((! ILLEGAL_RANGE(chars[0])),"U+0080/U+0100 - U+FFFF data lost");
-                return JS_FALSE;
             }
 #endif // DEBUG
             *((char*)d) = bytes[0];
             break;
         }
     case nsXPTType::T_WCHAR  :
         {
             const jschar* chars=nsnull;