Bug 1545851, part 2 - Mark nsISupportsPrimitive and subinterfaces as builtinclass. r=froydnj
authorAndrew McCreight <continuation@gmail.com>
Mon, 22 Apr 2019 14:35:18 +0000
changeset 470365 1ee2dbf025098374e660fd92b1cee4f13c7b695e
parent 470364 9dec6983ccaca948dcde3db9cdd6a9ee94d53c3c
child 470366 3073770e06f157040f4c64951b7e8425e1ad7bbe
push id35903
push useropoprus@mozilla.com
push dateMon, 22 Apr 2019 21:46:44 +0000
treeherdermozilla-central@a11bd690638f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1545851
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545851, part 2 - Mark nsISupportsPrimitive and subinterfaces as builtinclass. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D28287
modules/libpref/nsIPrefLocalizedString.idl
xpcom/components/nsICategoryManager.idl
xpcom/ds/nsISupportsPrimitives.idl
--- a/modules/libpref/nsIPrefLocalizedString.idl
+++ b/modules/libpref/nsIPrefLocalizedString.idl
@@ -11,17 +11,17 @@
  * nsISupportsString so the preferences service can have a unique identifier
  * to distinguish between requests for normal wide strings (nsISupportsString)
  * and "localized" wide strings, which get their default values from properites
  * files.
  *
  * @see nsIPrefBranch
  * @see nsISupportsString
  */
-[scriptable, uuid(ae419e24-1dd1-11b2-b39a-d3e5e7073802)]
+[scriptable, builtinclass, uuid(ae419e24-1dd1-11b2-b39a-d3e5e7073802)]
 interface nsIPrefLocalizedString : nsISupportsString {};
 
 %{C++
 
 #define NS_PREFLOCALIZEDSTRING_CID                     \
   { /* {064d9cee-1dd2-11b2-83e3-d25ab0193c26} */       \
     0x064d9cee,                                        \
     0x1dd2,                                            \
--- a/xpcom/components/nsICategoryManager.idl
+++ b/xpcom/components/nsICategoryManager.idl
@@ -11,17 +11,17 @@ interface nsISimpleEnumerator;
 %{C++
 #include "nsString.h"
 %}
 
 /*
  * nsICategoryManager
  */
 
-[scriptable, uuid(de021d54-57a3-4025-ae63-4c8eedbe74c0)]
+[scriptable, builtinclass, uuid(de021d54-57a3-4025-ae63-4c8eedbe74c0)]
 interface nsICategoryEntry : nsISupportsCString
 {
   readonly attribute ACString entry;
 
   readonly attribute ACString value;
 };
 
 [builtinclass, scriptable, uuid(3275b2cd-af6d-429a-80d7-f0c5120342ac)]
@@ -29,17 +29,17 @@ interface nsICategoryManager : nsISuppor
 {
     /**
      * Get the value for the given category's entry.
      * @param aCategory The name of the category ("protocol")
      * @param aEntry The entry you're looking for ("http")
      * @return The value.
      */
     ACString getCategoryEntry(in ACString aCategory, in ACString aEntry);
-    
+
     /**
      * Add an entry to a category.
      * @param aCategory The name of the category ("protocol")
      * @param aEntry The entry to be added ("http")
      * @param aValue The value for the entry ("moz.httprulez.1")
      * @param aPersist Should this data persist between invocations?
      * @param aReplace Should we replace an existing entry?
      * @return Previous entry, if any
@@ -130,9 +130,8 @@ interface nsICategoryManager : nsISuppor
     template<size_t N>
     nsresult
     EnumerateCategory(const char (&aCategory)[N], nsISimpleEnumerator** aResult)
     {
         return EnumerateCategory(nsLiteralCString(aCategory), aResult);
     }
     %}
 };
-
--- a/xpcom/ds/nsISupportsPrimitives.idl
+++ b/xpcom/ds/nsISupportsPrimitives.idl
@@ -9,17 +9,17 @@
 
 /**
  * Primitive base interface.
  *
  * These first three are pointer types and do data copying
  * using the nsIMemory. Be careful!
  */
 
-[scriptable, uuid(d0d4b136-1dd1-11b2-9371-f0727ef827c0)]
+[scriptable, builtinclass, uuid(d0d4b136-1dd1-11b2-9371-f0727ef827c0)]
 interface nsISupportsPrimitive : nsISupports
 {
     const unsigned short TYPE_ID                = 1;
     const unsigned short TYPE_CSTRING           = 2;
     const unsigned short TYPE_STRING            = 3;
     const unsigned short TYPE_PRBOOL            = 4;
     const unsigned short TYPE_PRUINT8           = 5;
     const unsigned short TYPE_PRUINT16          = 6;
@@ -37,188 +37,186 @@ interface nsISupportsPrimitive : nsISupp
 
     readonly attribute unsigned short type;
 };
 
 /**
  * Scriptable storage for nsID structures
  */
 
-[scriptable, uuid(d18290a0-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(d18290a0-4a1c-11d3-9890-006008962422)]
 interface nsISupportsID : nsISupportsPrimitive
 {
     attribute nsIDPtr data;
     string toString();
 };
 
 /**
  * Scriptable storage for ASCII strings
  */
 
-[scriptable, uuid(d65ff270-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(d65ff270-4a1c-11d3-9890-006008962422)]
 interface nsISupportsCString : nsISupportsPrimitive
 {
     attribute ACString data;
     string toString();
 };
 
 /**
  * Scriptable storage for Unicode strings
  */
 
-[scriptable, uuid(d79dc970-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(d79dc970-4a1c-11d3-9890-006008962422)]
 interface nsISupportsString : nsISupportsPrimitive
 {
     attribute AString data;
     wstring toString();
 };
 
 /**
  * The rest are truly primitive and are passed by value
- */ 
+ */
 
 /**
  * Scriptable storage for booleans
  */
 
-[scriptable, uuid(ddc3b490-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(ddc3b490-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRBool : nsISupportsPrimitive
 {
     attribute boolean data;
     string toString();
 };
 
 /**
  * Scriptable storage for 8-bit integers
  */
 
-[scriptable, uuid(dec2e4e0-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(dec2e4e0-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRUint8 : nsISupportsPrimitive
 {
     attribute uint8_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for unsigned 16-bit integers
  */
 
-[scriptable, uuid(dfacb090-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(dfacb090-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRUint16 : nsISupportsPrimitive
 {
     attribute uint16_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for unsigned 32-bit integers
  */
 
-[scriptable, uuid(e01dc470-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e01dc470-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRUint32 : nsISupportsPrimitive
 {
     attribute uint32_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for 64-bit integers
  */
 
-[scriptable, uuid(e13567c0-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e13567c0-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRUint64 : nsISupportsPrimitive
 {
     attribute uint64_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for NSPR date/time values
  */
 
-[scriptable, uuid(e2563630-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e2563630-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRTime : nsISupportsPrimitive
 {
     attribute PRTime data;
     string toString();
 };
 
 /**
  * Scriptable storage for single character values
  * (often used to store an ASCII character)
  */
 
-[scriptable, uuid(e2b05e40-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e2b05e40-4a1c-11d3-9890-006008962422)]
 interface nsISupportsChar : nsISupportsPrimitive
 {
     attribute char data;
     string toString();
 };
 
 /**
  * Scriptable storage for 16-bit integers
  */
 
-[scriptable, uuid(e30d94b0-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e30d94b0-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRInt16 : nsISupportsPrimitive
 {
     attribute int16_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for 32-bit integers
  */
 
-[scriptable, uuid(e36c5250-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e36c5250-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRInt32 : nsISupportsPrimitive
 {
     attribute int32_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for 64-bit integers
  */
 
-[scriptable, uuid(e3cb0ff0-4a1c-11d3-9890-006008962422)]
+[scriptable, builtinclass, uuid(e3cb0ff0-4a1c-11d3-9890-006008962422)]
 interface nsISupportsPRInt64 : nsISupportsPrimitive
 {
     attribute int64_t data;
     string toString();
 };
 
 /**
  * Scriptable storage for floating point numbers
  */
 
-[scriptable, uuid(abeaa390-4ac0-11d3-baea-00805f8a5dd7)]
+[scriptable, builtinclass, uuid(abeaa390-4ac0-11d3-baea-00805f8a5dd7)]
 interface nsISupportsFloat : nsISupportsPrimitive
 {
     attribute float data;
     string toString();
 };
 
 /**
  * Scriptable storage for doubles
  */
 
-[scriptable, uuid(b32523a0-4ac0-11d3-baea-00805f8a5dd7)]
+[scriptable, builtinclass, uuid(b32523a0-4ac0-11d3-baea-00805f8a5dd7)]
 interface nsISupportsDouble : nsISupportsPrimitive
 {
     attribute double data;
     string toString();
 };
 
 /**
  * Scriptable storage for other XPCOM objects
  */
 
-[scriptable, uuid(995ea724-1dd1-11b2-9211-c21bdd3e7ed0)]
+[scriptable, builtinclass, uuid(995ea724-1dd1-11b2-9211-c21bdd3e7ed0)]
 interface nsISupportsInterfacePointer : nsISupportsPrimitive
 {
     attribute nsISupports data;
     attribute nsIDPtr dataIID;
 
     string toString();
 };
-
-