Bug 906116 - part4: Remove NS_STYLE_HINT_FRAMECHANGE. r=dbaron
☠☠ backed out by 3a2cec4fd398 ☠ ☠
authorJeremy Chen <jeremychen@mozilla.com>
Wed, 06 Jul 2016 09:59:56 +0800
changeset 303781 1ec6e0357c4219fcbfa68f027b619bd8cedacbe1
parent 303780 8c1f9996a7d652b313070ef160105149201d8cb2
child 303782 339b5c5d3595fcbf3cafd35df8a2a2ecce484b5a
push id30401
push usercbook@mozilla.com
push dateWed, 06 Jul 2016 09:40:34 +0000
treeherdermozilla-central@a7d6bb9e7d12 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs906116
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 906116 - part4: Remove NS_STYLE_HINT_FRAMECHANGE. r=dbaron MozReview-Commit-ID: IXPWY2B6k48
layout/base/RestyleManager.cpp
layout/base/nsChangeHint.h
--- a/layout/base/RestyleManager.cpp
+++ b/layout/base/RestyleManager.cpp
@@ -5167,21 +5167,17 @@ RestyleManager::ChangeHintToString(nsCha
   };
   uint32_t hint = aHint & ((1 << ArrayLength(names)) - 1);
   uint32_t rest = aHint & ~((1 << ArrayLength(names)) - 1);
   if (hint == nsChangeHint_Hints_NotHandledForDescendants) {
     result.AppendLiteral("nsChangeHint_Hints_NotHandledForDescendants");
     hint = 0;
     any = true;
   } else {
-    if ((hint & NS_STYLE_HINT_FRAMECHANGE) == NS_STYLE_HINT_FRAMECHANGE) {
-      result.AppendLiteral("NS_STYLE_HINT_FRAMECHANGE");
-      hint = hint & ~NS_STYLE_HINT_FRAMECHANGE;
-      any = true;
-    } else if ((hint & NS_STYLE_HINT_REFLOW) == NS_STYLE_HINT_REFLOW) {
+    if ((hint & NS_STYLE_HINT_REFLOW) == NS_STYLE_HINT_REFLOW) {
       result.AppendLiteral("NS_STYLE_HINT_REFLOW");
       hint = hint & ~NS_STYLE_HINT_REFLOW;
       any = true;
     } else if ((hint & nsChangeHint_AllReflowHints) == nsChangeHint_AllReflowHints) {
       result.AppendLiteral("nsChangeHint_AllReflowHints");
       hint = hint & ~nsChangeHint_AllReflowHints;
       any = true;
     } else if ((hint & NS_STYLE_HINT_VISUAL) == NS_STYLE_HINT_VISUAL) {
--- a/layout/base/nsChangeHint.h
+++ b/layout/base/nsChangeHint.h
@@ -354,18 +354,16 @@ inline nsChangeHint NS_HintsNotHandledFo
 #define nsChangeHint_AllReflowHints                     \
   nsChangeHint(nsChangeHint_NeedReflow |                \
                nsChangeHint_ReflowChangesSizeOrPosition|\
                nsChangeHint_ClearAncestorIntrinsics |   \
                nsChangeHint_ClearDescendantIntrinsics | \
                nsChangeHint_NeedDirtyReflow)
 #define NS_STYLE_HINT_REFLOW \
   nsChangeHint(NS_STYLE_HINT_VISUAL | nsChangeHint_AllReflowHints)
-#define NS_STYLE_HINT_FRAMECHANGE \
-  nsChangeHint(NS_STYLE_HINT_REFLOW | nsChangeHint_ReconstructFrame)
 
 #define nsChangeHint_Hints_CanIgnoreIfNotVisible   \
   nsChangeHint(NS_STYLE_HINT_VISUAL |              \
                nsChangeHint_NeutralChange |        \
                nsChangeHint_UpdateOpacityLayer |   \
                nsChangeHint_UpdateTransformLayer | \
                nsChangeHint_UpdateUsesOpacity)